Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1137033004: [Session restore] Add DontRestoreBackgroundTabs group to collect stats. (Closed)

Created:
5 years, 7 months ago by Georges Khalil
Modified:
5 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, chrisha, gab
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Session restore] Add DontRestoreBackgroundTabs group to collect stats. BUG=472772 Committed: https://crrev.com/1912f4a4c9126ed44b1d660cb4451be204738433 Cr-Commit-Position: refs/heads/master@{#329245}

Patch Set 1 #

Patch Set 2 : Change experiment name to the new/correct one. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -2 lines) Patch
M chrome/browser/sessions/session_restore_delegate.cc View 1 2 chunks +20 lines, -2 lines 0 comments Download
M chrome/browser/sessions/session_restore_stats_collector.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/sessions/session_restore_stats_collector.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Georges Khalil
PTAL. This adds the lazy mode (no loading) mode of background tabs. The goal here ...
5 years, 7 months ago (2015-05-11 20:11:53 UTC) #2
sky
LGTM
5 years, 7 months ago (2015-05-11 20:31:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137033004/1
5 years, 7 months ago (2015-05-11 20:33:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137033004/20001
5 years, 7 months ago (2015-05-11 21:05:16 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-11 22:00:05 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 22:00:54 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1912f4a4c9126ed44b1d660cb4451be204738433
Cr-Commit-Position: refs/heads/master@{#329245}

Powered by Google App Engine
This is Rietveld 408576698