Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1137033002: PPC: Add a MathFloor stub generated with TurboFan (Closed)

Created:
5 years, 7 months ago by MTBrandyberry
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Add a MathFloor stub generated with TurboFan Port abc35080b33cc31e47b9913e64ac99ec687c6b65 Original commit message: This stub will be used as the basis of a Math.floor-specific CallIC to detect and track calls to floor that return -0. Along the way: - Create a TurboFanCodeStub super class from which the StringLength and MathRound TF stubs derive. - Fix the ugly hack that passes the first stub parameter as the "this" pointer in the the TF-compiled JS function. - Fix bugs in the ia32/x64 disassembler. R=danno@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/58c40db2558050c21648ff19d0e1f4b3b9297527 Cr-Commit-Position: refs/heads/master@{#28341}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 7 months ago (2015-05-11 13:59:54 UTC) #1
dstence
lgtm
5 years, 7 months ago (2015-05-11 14:10:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137033002/1
5 years, 7 months ago (2015-05-11 14:11:03 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 14:33:34 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 14:33:47 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58c40db2558050c21648ff19d0e1f4b3b9297527
Cr-Commit-Position: refs/heads/master@{#28341}

Powered by Google App Engine
This is Rietveld 408576698