Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 1136983004: Revert of Implement lossy pref behavior for JsonPrefStore. (Closed)

Created:
5 years, 7 months ago by robert.bradford
Modified:
5 years, 7 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@prefs-fix-flags
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement lossy pref behavior for JsonPrefStore. (patchset #12 id:220001 of https://codereview.chromium.org/1127963002/) Reason for revert: Linux Valgrind & MSan bot went red due to use of an uninitialized value (newly added POD member missing from second constructor.) http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%283%29/builds/45675 Original issue's description: > Implement lossy pref behavior for JsonPrefStore. > > Writes to lossy prefs should not trigger writes to disk to be scheduled. > This behavior is implemented for JsonPrefStore. CommitPendingWrites will > ensure that all outstanding lossy writes are also written to disk. > > BUG=476800 > > Committed: https://crrev.com/e9d8c9882ca272c803711e26ded4dd7d5203a59e > Cr-Commit-Position: refs/heads/master@{#329122} TBR=mnissler@chromium.org,raymes@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=476800 Committed: https://crrev.com/74bb4ded177e5058878ae3d0e510ef83595f8f3a Cr-Commit-Position: refs/heads/master@{#329169}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -157 lines) Patch
M base/prefs/json_pref_store.h View 4 chunks +0 lines, -7 lines 0 comments Download
M base/prefs/json_pref_store.cc View 8 chunks +8 lines, -23 lines 0 comments Download
M base/prefs/json_pref_store_unittest.cc View 6 chunks +8 lines, -127 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
robert.bradford
Created Revert of Implement lossy pref behavior for JsonPrefStore.
5 years, 7 months ago (2015-05-11 17:14:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136983004/1
5 years, 7 months ago (2015-05-11 17:16:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 17:33:29 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 17:35:45 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74bb4ded177e5058878ae3d0e510ef83595f8f3a
Cr-Commit-Position: refs/heads/master@{#329169}

Powered by Google App Engine
This is Rietveld 408576698