Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: sync/syncable/directory.h

Issue 1136953013: Sync: Change Local IDs to GUID based to avoid ID collision (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changed comments for Directory::NextId() Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sync/syncable/directory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/syncable/directory.h
diff --git a/sync/syncable/directory.h b/sync/syncable/directory.h
index 4f45cdfe18bf0e0e53e9d1df3b2b27283833e52c..d8a02d9b1a6102179acbb81239702367c713b445 100644
--- a/sync/syncable/directory.h
+++ b/sync/syncable/directory.h
@@ -110,8 +110,6 @@ class SYNC_EXPORT Directory {
// The store birthday we were given by the server. Contents are opaque to
// the client.
std::string store_birthday;
- // The next local ID that has not been used with this cache-GUID.
- int64 next_id;
// The serialized bag of chips we were given by the server. Contents are
// opaque to the client. This is the serialization of a message of type
// ChipBag defined in sync.proto. It can contains NULL characters.
@@ -269,7 +267,7 @@ class SYNC_EXPORT Directory {
transaction_observer);
int64 NextMetahandle();
- // Returns a negative integer unique to this client.
+ // Generates next client ID based on a randomly generated GUID.
syncable::Id NextId();
bool good() const { return NULL != kernel_; }
« no previous file with comments | « no previous file | sync/syncable/directory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698