Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Unified Diff: sync/syncable/directory_unittest.cc

Issue 1136953013: Sync: Change Local IDs to GUID based to avoid ID collision (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed setting KERNEL_SHARE_INFO_DIRTY when incrementing transaction version Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/syncable/directory_unittest.cc
diff --git a/sync/syncable/directory_unittest.cc b/sync/syncable/directory_unittest.cc
index 690af4ff4d6993b190872508f07e230f6db2296a..96aaa70915f0ce52efa4b68248972578bdd28e4d 100644
--- a/sync/syncable/directory_unittest.cc
+++ b/sync/syncable/directory_unittest.cc
@@ -1625,36 +1625,6 @@ TEST_F(SyncableDirectoryTest, ToValue) {
dir()->SaveChanges();
}
-// Test that the bookmark tag generation algorithm remains unchanged.
-TEST_F(SyncableDirectoryTest, BookmarkTagTest) {
- // This test needs its own InMemoryDirectoryBackingStore because it needs to
- // call request_consistent_cache_guid().
- InMemoryDirectoryBackingStore* store = new InMemoryDirectoryBackingStore("x");
-
- // The two inputs that form the bookmark tag are the directory's cache_guid
- // and its next_id value. We don't need to take any action to ensure
- // consistent next_id values, but we do need to explicitly request that our
- // InMemoryDirectoryBackingStore always return the same cache_guid.
- store->request_consistent_cache_guid();
-
- Directory dir(store, unrecoverable_error_handler(), NULL, NULL, NULL);
- ASSERT_EQ(
- OPENED,
- dir.Open("x", directory_change_delegate(), NullTransactionObserver()));
-
- {
- WriteTransaction wtrans(FROM_HERE, UNITTEST, &dir);
- MutableEntry bm(&wtrans, CREATE, BOOKMARKS, wtrans.root_id(), "bm");
- bm.PutIsUnsynced(true);
-
- // If this assertion fails, that might indicate that the algorithm used to
- // generate bookmark tags has been modified. This could have implications
- // for bookmark ordering. Please make sure you know what you're doing if
- // you intend to make such a change.
- ASSERT_EQ("6wHRAb3kbnXV5GHrejp4/c1y5tw=", bm.GetUniqueBookmarkTag());
- }
-}
-
// A thread that creates a bunch of directory entries.
class StressTransactionsDelegate : public base::PlatformThread::Delegate {
public:

Powered by Google App Engine
This is Rietveld 408576698