Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1136953012: Move DispatchSourceMach from //sandbox/mac to //base/mac. (Closed)

Created:
5 years, 7 months ago by Robert Sesek
Modified:
5 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move DispatchSourceMach from //sandbox/mac to //base/mac. BUG=487674 Committed: https://crrev.com/6cba592c47a536fe2b5cb10f8d650f8ba4c99766 Cr-Commit-Position: refs/heads/master@{#329700}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -274 lines) Patch
M base/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M base/base.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M base/base.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A + base/mac/dispatch_source_mach.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + base/mac/dispatch_source_mach.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + base/mac/dispatch_source_mach_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M sandbox/mac/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D sandbox/mac/dispatch_source_mach.h View 1 chunk +0 lines, -61 lines 0 comments Download
D sandbox/mac/dispatch_source_mach.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D sandbox/mac/dispatch_source_mach_unittest.cc View 1 chunk +0 lines, -119 lines 0 comments Download
M sandbox/mac/mach_message_server.h View 3 chunks +2 lines, -3 lines 0 comments Download
M sandbox/mac/mach_message_server.cc View 2 chunks +1 line, -2 lines 0 comments Download
M sandbox/mac/sandbox_mac.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M sandbox/mac/xpc_message_server.h View 3 chunks +2 lines, -3 lines 0 comments Download
M sandbox/mac/xpc_message_server.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Robert Sesek
5 years, 7 months ago (2015-05-13 17:12:25 UTC) #2
Nico
Re bug: Are kernel threads cheaper than user space threads? What's the motivation?
5 years, 7 months ago (2015-05-13 17:29:06 UTC) #3
Robert Sesek
On 2015/05/13 17:29:06, Nico wrote: > Re bug: Are kernel threads cheaper than user space ...
5 years, 7 months ago (2015-05-13 17:56:59 UTC) #4
Nico
lgtm
5 years, 7 months ago (2015-05-13 19:07:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136953012/1
5 years, 7 months ago (2015-05-13 19:13:38 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 19:49:18 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 19:51:01 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6cba592c47a536fe2b5cb10f8d650f8ba4c99766
Cr-Commit-Position: refs/heads/master@{#329700}

Powered by Google App Engine
This is Rietveld 408576698