Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1136953010: X87: Resolve references to "this" the same way as normal variables (Closed)

Created:
5 years, 7 months ago by chunyang.dai
Modified:
5 years, 7 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Resolve references to "this" the same way as normal variables port bd56d279b612f92d2d1d25f92d32fe7f42a455ca (R28340). original commit message: Make the parser handle references to "this" as unresolved variables, so the same logic as for the rest of function parameters is used for the receiver. Minor additions to the code generation handle copying the receiver to the context, along with the rest of the function parameters. Based on work by Adrian Perez de Castro <aperez@igalia.com>;. BUG= Committed: https://crrev.com/6eea252463648d81cf3ae128e6f0d5f815a108bb Cr-Commit-Position: refs/heads/master@{#28390}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M src/x87/full-codegen-x87.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 7 months ago (2015-05-13 10:26:57 UTC) #2
Weiliang
lgtm
5 years, 7 months ago (2015-05-13 10:37:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136953010/1
5 years, 7 months ago (2015-05-13 10:37:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 11:18:45 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 11:19:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6eea252463648d81cf3ae128e6f0d5f815a108bb
Cr-Commit-Position: refs/heads/master@{#28390}

Powered by Google App Engine
This is Rietveld 408576698