Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1136953008: Add dark action bar color to colors.xml (Closed)

Created:
5 years, 7 months ago by Changwan Ryu
Modified:
5 years, 7 months ago
Reviewers:
Ted C, newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add dark action bar color to colors.xml We want to use the same color between Chrome and an external activity in GMS core, and we can launch this activity with a custom color, so this change makes the color accessible in both places. BUG=480598 Committed: https://crrev.com/5a47aacd7961fbdc875ff4e7c58ee607195dd7a1 Cr-Commit-Position: refs/heads/master@{#329324}

Patch Set 1 #

Total comments: 2

Patch Set 2 : moved to common colors section #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/android/java/res/values-v17/styles.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/res/values/colors.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Changwan Ryu
5 years, 7 months ago (2015-05-12 00:42:51 UTC) #2
newt (away)
lgtm after comment https://codereview.chromium.org/1136953008/diff/1/chrome/android/java/res/values/colors.xml File chrome/android/java/res/values/colors.xml (right): https://codereview.chromium.org/1136953008/diff/1/chrome/android/java/res/values/colors.xml#newcode94 chrome/android/java/res/values/colors.xml:94: <color name="dark_action_bar_color">#263238</color> this probably belongs under ...
5 years, 7 months ago (2015-05-12 00:46:55 UTC) #3
Changwan Ryu
https://codereview.chromium.org/1136953008/diff/1/chrome/android/java/res/values/colors.xml File chrome/android/java/res/values/colors.xml (right): https://codereview.chromium.org/1136953008/diff/1/chrome/android/java/res/values/colors.xml#newcode94 chrome/android/java/res/values/colors.xml:94: <color name="dark_action_bar_color">#263238</color> On 2015/05/12 00:46:55, newt wrote: > this ...
5 years, 7 months ago (2015-05-12 00:53:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136953008/20001
5 years, 7 months ago (2015-05-12 00:55:22 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-12 02:16:58 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 02:18:04 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5a47aacd7961fbdc875ff4e7c58ee607195dd7a1
Cr-Commit-Position: refs/heads/master@{#329324}

Powered by Google App Engine
This is Rietveld 408576698