Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1136943004: add flags to recovery executable. (Closed)

Created:
5 years, 7 months ago by xiaoling
Modified:
5 years, 7 months ago
Reviewers:
waffles, Sorin Jianu, sorin
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add flag '/deferredrun' to recovery executable for elevated install of recovery component so we can distinguish from first install. Also changed version arg format from --version to /version. BUG= Committed: https://crrev.com/5585b3e21ea757b82f3fc4308bffcf5a0734b467 Cr-Commit-Position: refs/heads/master@{#330406}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : removed executable bit #

Total comments: 2

Patch Set 4 : refactor command line preparation #

Patch Set 5 : #

Total comments: 1

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -18 lines) Patch
M chrome/browser/component_updater/recovery_component_installer.cc View 1 2 3 4 5 3 chunks +33 lines, -18 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
xiaoling
5 years, 7 months ago (2015-05-15 18:38:48 UTC) #2
waffles
lgtm
5 years, 7 months ago (2015-05-15 20:48:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136943004/40001
5 years, 7 months ago (2015-05-16 00:13:31 UTC) #8
Sorin Jianu
thank you X! https://codereview.chromium.org/1136943004/diff/40001/chrome/browser/component_updater/recovery_component_installer.cc File chrome/browser/component_updater/recovery_component_installer.cc (right): https://codereview.chromium.org/1136943004/diff/40001/chrome/browser/component_updater/recovery_component_installer.cc#newcode349 chrome/browser/component_updater/recovery_component_installer.cc:349: std::string version_string = "/version "; As ...
5 years, 7 months ago (2015-05-16 00:19:11 UTC) #11
Sorin Jianu
thank you X!
5 years, 7 months ago (2015-05-16 00:19:15 UTC) #12
xiaoling
Thank you. PTAL. https://codereview.chromium.org/1136943004/diff/40001/chrome/browser/component_updater/recovery_component_installer.cc File chrome/browser/component_updater/recovery_component_installer.cc (right): https://codereview.chromium.org/1136943004/diff/40001/chrome/browser/component_updater/recovery_component_installer.cc#newcode349 chrome/browser/component_updater/recovery_component_installer.cc:349: std::string version_string = "/version "; On ...
5 years, 7 months ago (2015-05-16 01:20:09 UTC) #13
Sorin Jianu
lgtm Thank you! https://codereview.chromium.org/1136943004/diff/80001/chrome/browser/component_updater/recovery_component_installer.cc File chrome/browser/component_updater/recovery_component_installer.cc (right): https://codereview.chromium.org/1136943004/diff/80001/chrome/browser/component_updater/recovery_component_installer.cc#newcode162 chrome/browser/component_updater/recovery_component_installer.cc:162: base::CommandLine cmdline = GetRecoveryInstallCommandLine( can cmdline ...
5 years, 7 months ago (2015-05-18 17:28:00 UTC) #14
Sorin Jianu
lgtm Thank you!
5 years, 7 months ago (2015-05-18 17:28:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136943004/100001
5 years, 7 months ago (2015-05-18 19:12:36 UTC) #18
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 7 months ago (2015-05-18 20:44:15 UTC) #19
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:42:29 UTC) #20
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/5585b3e21ea757b82f3fc4308bffcf5a0734b467
Cr-Commit-Position: refs/heads/master@{#330406}

Powered by Google App Engine
This is Rietveld 408576698