Revert 167808 - Get rid of use of CreateStringValue in chromeos/ directory.

chrome/browser/chromeos/extensions/file_browser_private_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/file_browser_private_api.h"
 
 #include <sys/statvfs.h>
 #include <sys/stat.h>
 #include <sys/types.h>
 #include <utime.h>
@@ skipping 1328 matching lines @@
   if (!args_->GetString(0, &file_url)) {
     return false;
   }
 
   std::string mount_type_str;
   if (!args_->GetString(1, &mount_type_str)) {
     return false;
   }
 
   // Set default return source path to the empty string.
-  SetResult(new base::StringValue(""));
+  SetResult(Value::CreateStringValue(""));
 
   chromeos::MountType mount_type =
       DiskMountManager::MountTypeFromString(mount_type_str);
   switch (mount_type) {
     case chromeos::MOUNT_TYPE_INVALID: {
       error_ = "Invalid mount type";
       SendResponse(false);
       break;
     }
     case chromeos::MOUNT_TYPE_GDATA: {
       const bool success = true;
       // Pass back the drive mount point path as source path.
       const std::string& drive_path =
           drive::util::GetDriveMountPointPathAsString();
-      SetResult(new base::StringValue(drive_path));
+      SetResult(Value::CreateStringValue(drive_path));
       FileBrowserEventRouterFactory::GetForProfile(profile_)->
           MountDrive(base::Bind(&AddMountFunction::SendResponse,
                                 this,
                                 success));
       break;
     }
     default: {
       UrlList file_paths;
       file_paths.push_back(GURL(file_url));
 
@@ skipping 37 matching lines @@
   }
 }
 
 void AddMountFunction::OnMountedStateSet(const std::string& mount_type,
                                          const FilePath::StringType& file_name,
                                          drive::DriveFileError error,
                                          const FilePath& file_path) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   DiskMountManager* disk_mount_manager = DiskMountManager::GetInstance();
   // Pass back the actual source path of the mount point.
-  SetResult(new base::StringValue(file_path.value()));
+  SetResult(Value::CreateStringValue(file_path.value()));
   SendResponse(true);
   // MountPath() takes a std::string.
   disk_mount_manager->MountPath(file_path.AsUTF8Unsafe(),
                                 FilePath(file_name).Extension(), file_name,
                                 DiskMountManager::MountTypeFromString(
                                     mount_type));
 }
 
 RemoveMountFunction::RemoveMountFunction() {
 }
@@ skipping 986 matching lines @@
   return true;
 }
 
 void GetFileLocationsFunction::GetLocalPathsResponseOnUIThread(
     const SelectedFileInfoList& files) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   ListValue* locations = new ListValue;
   for (size_t i = 0; i < files.size(); ++i) {
     if (drive::util::IsUnderDriveMountPoint(files[i].file_path)) {
-      locations->Append(new base::StringValue("drive"));
+      locations->Append(Value::CreateStringValue("drive"));
     } else {
-      locations->Append(new base::StringValue("local"));
+      locations->Append(Value::CreateStringValue("local"));
     }
   }
 
   SetResult(locations);
   SendResponse(true);
 }
 
 GetDriveFilesFunction::GetDriveFilesFunction()
     : local_paths_(NULL) {
 }
@@ skipping 66 matching lines @@
 
 
 void GetDriveFilesFunction::OnFileReady(
     drive::DriveFileError error,
     const FilePath& local_path,
     const std::string& unused_mime_type,
     drive::DriveFileType file_type) {
   FilePath drive_path = remaining_drive_paths_.front();
 
   if (error == drive::DRIVE_FILE_OK) {
-    local_paths_->Append(new base::StringValue(local_path.value()));
+    local_paths_->Append(Value::CreateStringValue(local_path.value()));
     DVLOG(1) << "Got " << drive_path.value() << " as " << local_path.value();
 
     // TODO(benchan): If the file is a hosted document, a temporary JSON file
     // is created to represent the document. The JSON file is not cached and
     // should be deleted after use. We need to somehow communicate with
     // file_manager.js to manage the lifetime of the temporary file.
     // See crosbug.com/28058.
   } else {
-    local_paths_->Append(new base::StringValue(""));
+    local_paths_->Append(Value::CreateStringValue(""));
     DVLOG(1) << "Failed to get " << drive_path.value()
              << " with error code: " << error;
   }
 
   remaining_drive_paths_.pop();
 
   // Start getting the next file.
   GetFileOrSendResponse();
 }
 
@@ skipping 351 matching lines @@
       drive::DriveSystemServiceFactory::GetForProfile(profile_);
   // |system_service| is NULL if Drive is disabled.
   if (!system_service || !system_service->file_system())
     return false;
 
   FilePath directory_path = GetVirtualPathFromURL(GURL(file_url_as_string));
   system_service->file_system()->RequestDirectoryRefresh(directory_path);
 
   return true;
 }