Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Unified Diff: chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.mm

Issue 11369253: Fix crash when programatically closing media gallery dialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.mm b/chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.mm
index 946f5c2f3b7463711cb6de646c074f6ccf9d97c1..494005bd585c32e34d1806584c79bfdc76dcb40a 100644
--- a/chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.mm
+++ b/chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.mm
@@ -134,6 +134,8 @@ void MediaGalleriesDialogCocoa::SheetDidEnd(NSInteger result) {
if (window_)
window_->CloseConstrainedWindow();
break;
+ case NSRunStoppedResponse:
+ break;
default:
NOTREACHED();
break;
@@ -205,7 +207,7 @@ void MediaGalleriesDialogCocoa::DeleteDelegate() {
// As required by ConstrainedWindowMacDelegate, close the sheet if
// it's still open.
if (is_sheet_open())
- [NSApp endSheet:sheet()];
+ [NSApp endSheet:[alert_ window]];
controller_->DialogFinished(accepted_);
}

Powered by Google App Engine
This is Rietveld 408576698