Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6216)

Unified Diff: chrome/browser/ui/extensions/shell_window.h

Issue 11369237: Add a way to fetch window frame metrics from NativeShellWindow (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: change ShellWindowViews frame insets logic Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/shell_window.h
diff --git a/chrome/browser/ui/extensions/shell_window.h b/chrome/browser/ui/extensions/shell_window.h
index 2f8b89cd041c3ea5a52f2c0a33d3734e9f3b1f38..5ecf83f5702a58ff69b964ab2b3abc3036ba9efc 100644
--- a/chrome/browser/ui/extensions/shell_window.h
+++ b/chrome/browser/ui/extensions/shell_window.h
@@ -54,9 +54,9 @@ class ShellWindow : public content::NotificationObserver,
~CreateParams();
Frame frame;
- // Specify the initial bounds of the window. INT_MIN designates
- // 'unspecified' for any coordinate, and should be replaced with a default
- // value.
+ // Specify the initial content bounds of the window (excluding any window
+ // decorations). INT_MIN designates 'unspecified' for any coordinate, and
+ // should be replaced with a default value.
gfx::Rect bounds;
gfx::Size minimum_size;
@@ -88,10 +88,8 @@ class ShellWindow : public content::NotificationObserver,
Profile* profile() const { return profile_; }
const gfx::Image& app_icon() const { return app_icon_; }
- BaseWindow* GetBaseWindow();
- gfx::NativeWindow GetNativeWindow() {
- return GetBaseWindow()->GetNativeWindow();
- }
+ NativeShellWindow* GetBaseWindow();
+ gfx::NativeWindow GetNativeWindow();
// NativeShellWindows should call this to determine what the window's title
// is on startup and from within UpdateWindowTitle().

Powered by Google App Engine
This is Rietveld 408576698