Add a way to fetch window frame metrics from NativeShellWindow

chrome/browser/ui/gtk/browser_window_gtk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/browser_window_gtk.h"
 
 #include <gdk/gdkkeysyms.h>
 
 #include <algorithm>
 #include <string>
@@ skipping 694 matching lines @@
 
 void BrowserWindowGtk::FlashFrame(bool flash) {
   // May not be respected by all window managers.
   gtk_window_set_urgency_hint(window_, flash);
 }
 
 bool BrowserWindowGtk::IsAlwaysOnTop() const {
   return false;
 }
 
+gfx::Rect BrowserWindowGtk::ContentBoundsForWindowBounds(
+    const gfx::Rect& window_bounds) const {
+  return window_bounds;

[Evan Stade, 2012/11/14 21:20:59]

please at least add a comment of some sort to make it clear this isn't a real
implementation. I don't understand from your CL description whether you intend
to ever implement this one, or just the ShellWindowGtk one. If you dont' plan to
implement this one, why not just return gfx::Rect() to make it clear it's wrong
(instead of making it almost right)?

[jeremya, 2012/11/14 23:35:59]

Done, made it NOTIMPLEMENTED().

+}
+
+gfx::Rect BrowserWindowGtk::WindowBoundsForContentBounds(
+    const gfx::Rect& content_bounds) const {
+  return content_bounds;
+}
+
 gfx::NativeWindow BrowserWindowGtk::GetNativeWindow() {
   return window_;
 }
 
 BrowserWindowTesting* BrowserWindowGtk::GetBrowserWindowTesting() {
   NOTIMPLEMENTED();
   return NULL;
 }
 
 StatusBubble* BrowserWindowGtk::GetStatusBubble() {
@@ skipping 1718 matching lines @@
           wm_type == ui::WM_OPENBOX ||
           wm_type == ui::WM_XFWM4);
 }
 
 // static
 BrowserWindow* BrowserWindow::CreateBrowserWindow(Browser* browser) {
   BrowserWindowGtk* browser_window_gtk = new BrowserWindowGtk(browser);
   browser_window_gtk->Init();
   return browser_window_gtk;
 }