Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: tools/testing/dart/test_progress.dart

Issue 11369216: Added support for skipping redundant dart2js compilations. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_progress.dart
diff --git a/tools/testing/dart/test_progress.dart b/tools/testing/dart/test_progress.dart
index 68ee94572660968087aacf2ac5d6ba266899eba1..d34e738ca98513cdb5cf58ca26be2dbca3329c45 100644
--- a/tools/testing/dart/test_progress.dart
+++ b/tools/testing/dart/test_progress.dart
@@ -53,6 +53,10 @@ class ProgressIndicator {
}
_appendToFlakyFile(buf.toString());
}
+ for (var commandOutput in test.commandOutputs.values) {
+ if (commandOutput.compilationSkipped)
+ _skippedCompilations++;
+ }
if (test.lastCommandOutput.unexpectedOutput) {
_failedTests++;
@@ -71,6 +75,13 @@ class ProgressIndicator {
_allTestsKnown = true;
}
+ void _printSkippedCompilationInfo() {
+ if (_skippedCompilations > 0) {
+ print('\n$_skippedCompilations compilations were skipped because '
+ 'the previous output was already up to date\n');
ricow1 2012/11/19 08:19:17 indent this under the other string
kustermann 2012/11/19 10:26:04 Done.
+ }
+ }
+
void _printTimingInformation() {
if (_printTiming) {
// TODO: We should take all the commands into account
@@ -93,6 +104,7 @@ class ProgressIndicator {
void allDone() {
_printFailureSummary();
_printStatus();
+ _printSkippedCompilationInfo();
_printTimingInformation();
stdout.close();
stderr.close();
@@ -225,6 +237,7 @@ class ProgressIndicator {
int _foundTests = 0;
int _passedTests = 0;
int _failedTests = 0;
+ int _skippedCompilations = 0;
bool _allTestsKnown = false;
Date _startTime;
bool _printTiming;
@@ -252,6 +265,7 @@ abstract class CompactIndicator extends ProgressIndicator {
void allDone() {
stdout.write('\n'.charCodes);
_printFailureSummary();
+ _printSkippedCompilationInfo();
_printTimingInformation();
if (_failedTests > 0) {
// We may have printed many failure logs, so reprint the summary data.

Powered by Google App Engine
This is Rietveld 408576698