Added support for skipping redundant dart2js compilations.

tools/testing/dart/test_progress.dart

Index: tools/testing/dart/test_progress.dart
diff --git a/tools/testing/dart/test_progress.dart b/tools/testing/dart/test_progress.dart
index 528d921b4f72c2e6d0098af577b8c5ee1e86c47e..6726b075d83caa9524903c5c4fecebf8392b7510 100644
--- a/tools/testing/dart/test_progress.dart
+++ b/tools/testing/dart/test_progress.dart
@@ -41,6 +41,8 @@ class ProgressIndicator {
 
   void testAdded() { _foundTests++; }
 
+  void skippedCompilation() { _skippedCompilations++; }

[Bill Hesse, 2012/11/14 09:37:34]

Maybe compilationSkipped is a better name (just for this function, not the
counter or other functions)- it refers to an event that happened, rather than an
object that might have state, behavior, or persistence.

[kustermann, 2012/11/16 14:58:42]

CommandOutput contains now a compilationSkipped field.
On 2012/11/14 09:37:34, Bill Hesse wrote:

+
   void start(TestCase test) {
     _printStartProgress(test);
   }
@@ -71,6 +73,13 @@ class ProgressIndicator {
     _allTestsKnown = true;
   }
 
+  void _printSkippedCompilationInfo() {
+    if (_skippedCompilations > 0) {
+      print('\n$_skippedCompilations dart2js compilations were skipped because '

[ricow1, 2012/11/14 08:53:28]

I think you should make the text a little more generic by leaving out "dart2js"
in the sentence - I assume that we will eventually be doing something similar
for dart2dart.

[kustermann, 2012/11/16 14:58:42]

Done.

+          'the previous output was already up to date\n');

[ahe, 2012/11/14 18:46:16]

I would try to make this text shorter, for example:

'\nSkipped compiling ${_skippedCompilations} up-to-date files.\n'

[kustermann, 2012/11/16 14:58:42]

I think the current message is more descriptive. (Not the files are up-to-date
but rather the compiled output)
 
On 2012/11/14 18:46:16, ahe wrote:

+    }
+  }
+
   void _printTimingInformation() {
     if (_printTiming) {
       Duration d = (new Date.now()).difference(_startTime);
@@ -92,6 +101,7 @@ class ProgressIndicator {
   void allDone() {
     _printFailureSummary();
     _printStatus();
+    _printSkippedCompilationInfo();

[Bill Hesse, 2012/11/14 09:37:34]

In the long run, we may not want to print this out.

[ricow1, 2012/11/14 09:47:32]

I really think we should, at least have a flag that makes us do it (so, e.g. on
the buildbot you can actually always see this).

[kustermann, 2012/11/16 14:58:42]

We could make it depend on '--report' but the ProgressIndicator doesn't get
passed a configuration object. For now, let's just keep this.
On 2012/11/14 09:47:32, ricow1 wrote:

     _printTimingInformation();
     stdout.close();
     stderr.close();
@@ -224,6 +234,7 @@ class ProgressIndicator {
   int _foundTests = 0;
   int _passedTests = 0;
   int _failedTests = 0;
+  int _skippedCompilations = 0;
   bool _allTestsKnown = false;
   Date _startTime;
   bool _printTiming;
@@ -251,6 +262,7 @@ abstract class CompactIndicator extends ProgressIndicator {
   void allDone() {
     stdout.write('\n'.charCodes);
     _printFailureSummary();
+    _printSkippedCompilationInfo();
     _printTimingInformation();
     if (_failedTests > 0) {
       // We may have printed many failure logs, so reprint the summary data.