Added support for skipping redundant dart2js compilations.

tools/testing/dart/test_progress.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library("test_progress");
 
 #import("dart:io");
 #import("test_runner.dart");
 #import("test_suite.dart");
 #import("status_file_parser.dart");
@@ skipping 23 matching lines @@
       case 'diff':
         return new DiffProgressIndicator(startTime, printTiming);
       default:
         assert(false);
         break;
     }
   }
 
   void testAdded() { _foundTests++; }
 
+  void skippedCompilation() { _skippedCompilations++; }

[Bill Hesse, 2012/11/14 09:37:34]

Maybe compilationSkipped is a better name (just for this function, not the
counter or other functions)- it refers to an event that happened, rather than an
object that might have state, behavior, or persistence.

[kustermann, 2012/11/16 14:58:42]

CommandOutput contains now a compilationSkipped field.
On 2012/11/14 09:37:34, Bill Hesse wrote:

+
   void start(TestCase test) {
     _printStartProgress(test);
   }
 
   void done(TestCase test) {
     if (test.isFlaky && test.output.result != PASS) {
       var buf = new StringBuffer();
       for (var l in _buildFailureOutput(test)) {
         buf.add("$l\n");
       }
@@ skipping 10 matching lines @@
     // If we need to print timing information we hold on to all completed
     // tests.
     if (_printTiming) _tests.add(test);
   }
 
   void allTestsKnown() {
     if (!_allTestsKnown) SummaryReport.printReport();
     _allTestsKnown = true;
   }
 
+  void _printSkippedCompilationInfo() {
+    if (_skippedCompilations > 0) {
+      print('\n$_skippedCompilations dart2js compilations were skipped because '

[ricow1, 2012/11/14 08:53:28]

I think you should make the text a little more generic by leaving out "dart2js"
in the sentence - I assume that we will eventually be doing something similar
for dart2dart.

[kustermann, 2012/11/16 14:58:42]

Done.

+          'the previous output was already up to date\n');

[ahe, 2012/11/14 18:46:16]

I would try to make this text shorter, for example:

'\nSkipped compiling ${_skippedCompilations} up-to-date files.\n'

[kustermann, 2012/11/16 14:58:42]

I think the current message is more descriptive. (Not the files are up-to-date
but rather the compiled output)
 
On 2012/11/14 18:46:16, ahe wrote:

+    }
+  }
+
   void _printTimingInformation() {
     if (_printTiming) {
       Duration d = (new Date.now()).difference(_startTime);
       print('\n--- Total time: ${_timeString(d)} ---');
       _tests.sort((a, b) {
         Duration aDuration = a.output.time;
         Duration bDuration = b.output.time;
         return bDuration.inMilliseconds - aDuration.inMilliseconds;
       });
       for (int i = 0; i < 20 && i < _tests.length; i++) {
         var name = _tests[i].displayName;
         var duration = _tests[i].output.time;
         var configuration = _tests[i].configurationString;
         print('${duration} - $configuration $name');
       }
     }
   }
 
   void allDone() {
     _printFailureSummary();
     _printStatus();
+    _printSkippedCompilationInfo();

[Bill Hesse, 2012/11/14 09:37:34]

In the long run, we may not want to print this out.

[ricow1, 2012/11/14 09:47:32]

I really think we should, at least have a flag that makes us do it (so, e.g. on
the buildbot you can actually always see this).

[kustermann, 2012/11/16 14:58:42]

We could make it depend on '--report' but the ProgressIndicator doesn't get
passed a configuration object. For now, let's just keep this.
On 2012/11/14 09:47:32, ricow1 wrote:

     _printTimingInformation();
     stdout.close();
     stderr.close();
     if (_failedTests > 0) exit(1);
   }
 
   void _printStartProgress(TestCase test) {}
   void _printDoneProgress(TestCase test) {}
 
   String _pad(String s, int length) {
@@ skipping 112 matching lines @@
     fd.closeSync();
   }
 
   int get numFailedTests => _failedTests;
 
   int _completedTests() => _passedTests + _failedTests;
 
   int _foundTests = 0;
   int _passedTests = 0;
   int _failedTests = 0;
+  int _skippedCompilations = 0;
   bool _allTestsKnown = false;
   Date _startTime;
   bool _printTiming;
   List<TestCase> _tests;
   List<String> _failureSummary;
 }
 
 
 class SilentProgressIndicator extends ProgressIndicator {
   SilentProgressIndicator(Date startTime, bool printTiming)
       : super(startTime, printTiming);
   void testAdded() { }
   void start(TestCase test) { }
   void done(TestCase test) { }
   void _printStartProgress(TestCase test) { }
   void _printDoneProgress(TestCase test) { }
   void allTestsKnown() { }
   void allDone() { }
 }
 
 abstract class CompactIndicator extends ProgressIndicator {
   CompactIndicator(Date startTime, bool printTiming)
       : super(startTime, printTiming);
 
   void allDone() {
     stdout.write('\n'.charCodes);
     _printFailureSummary();
+    _printSkippedCompilationInfo();
     _printTimingInformation();
     if (_failedTests > 0) {
       // We may have printed many failure logs, so reprint the summary data.
       _printProgress();
       print('');
     }
     stdout.close();
     stderr.close();
     if (_failedTests > 0) exit(1);
   }
@@ skipping 198 matching lines @@
       print('');
       print('$config:');
       statuses.sort((a, b) => a.compareTo(b));
       for (String status in statuses) {
         print('  $status');
       }
     });
     _printStatus();
   }
 }