utils/tests/pub/test_pub.dart - Issue 11369210: Make RegExp constructor non-const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: utils/tests/pub/test_pub.dart

Issue 11369210: Make RegExp constructor non-const. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Clean up status files. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: utils/tests/pub/test_pub.dart

diff --git a/utils/tests/pub/test_pub.dart b/utils/tests/pub/test_pub.dart

index 3b45775d9316c60040f8e4daa7fd1a0b2e0e728b..0c06a418f0ed72080d73016a656cb1116f330bf1 100644

--- a/utils/tests/pub/test_pub.dart

+++ b/utils/tests/pub/test_pub.dart

@@ -409,7 +409,7 @@ String _packageName(String sourceName, description) {

switch (sourceName) {

case "git":

var url = description is String ? description : description['url'];

- return basename(url.replaceFirst(const RegExp(r"(\.git)?/?$"), ""));

+ return basename(url.replaceFirst(new RegExp(r"(\.git)?/?$"), ""));

case "hosted":

if (description is String) return description;

return description['name'];