tools/release/version.dart - Issue 11369210: Make RegExp constructor non-const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/release/version.dart

Issue 11369210: Make RegExp constructor non-const. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Clean up status files. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/release/version.dart

diff --git a/tools/release/version.dart b/tools/release/version.dart

index 92ca6242e7178b5d9b51a44821c0cf0162447137..7774e47553eb3a2f5f0e41edbba64c79c4035ca4 100644

--- a/tools/release/version.dart

+++ b/tools/release/version.dart

@@ -122,7 +122,7 @@ class Version {

int getRevisionFromSvnInfo(String info) {

if (info == null || info == '') return 0;

var lines = info.split("\n");

- RegExp exp = const RegExp(r"Last Changed Rev: (\d*)");

+ RegExp exp = new RegExp(r"Last Changed Rev: (\d*)");

for (var line in lines) {

if (exp.hasMatch(line)) {

String revisionString = (exp.firstMatch(line).group(1));

« no previous file with comments | « tests/language/reg_exp_test.dart ('k') | tools/testing/dart/multitest.dart » ('j') | no next file with comments »