Chromium Code Reviews| Index: net/url_request/url_request_test_util.h |
| diff --git a/net/url_request/url_request_test_util.h b/net/url_request/url_request_test_util.h |
| index 41be00882396048e4c0c2ac53eaf3ae90e4ddae9..f02f013fbc4ab98e876ea3918bb80bb1964398d6 100644 |
| --- a/net/url_request/url_request_test_util.h |
| +++ b/net/url_request/url_request_test_util.h |
| @@ -41,9 +41,11 @@ |
| using base::TimeDelta; |
| +namespace net { |
| + |
| //----------------------------------------------------------------------------- |
| -class TestURLRequestContext : public net::URLRequestContext { |
| +class TestURLRequestContext : public URLRequestContext { |
| public: |
| TestURLRequestContext(); |
| // Default constructor like TestURLRequestContext() but does not call |
| @@ -59,14 +61,14 @@ class TestURLRequestContext : public net::URLRequestContext { |
| bool initialized_; |
| protected: |
| - net::URLRequestContextStorage context_storage_; |
| + URLRequestContextStorage context_storage_; |
| }; |
| //----------------------------------------------------------------------------- |
| // Used to return a dummy context, which lives on the message loop |
| // given in the constructor. |
| -class TestURLRequestContextGetter : public net::URLRequestContextGetter { |
| +class TestURLRequestContextGetter : public URLRequestContextGetter { |
| public: |
| // |network_task_runner| must not be NULL. |
| explicit TestURLRequestContextGetter( |
| @@ -77,7 +79,7 @@ class TestURLRequestContextGetter : public net::URLRequestContextGetter { |
| const scoped_refptr<base::SingleThreadTaskRunner>& network_task_runner, |
| scoped_ptr<TestURLRequestContext> context); |
| - // net::URLRequestContextGetter implementation. |
| + // URLRequestContextGetter implementation. |
| virtual TestURLRequestContext* GetURLRequestContext() OVERRIDE; |
| virtual scoped_refptr<base::SingleThreadTaskRunner> |
| GetNetworkTaskRunner() const OVERRIDE; |
| @@ -92,7 +94,7 @@ class TestURLRequestContextGetter : public net::URLRequestContextGetter { |
| //----------------------------------------------------------------------------- |
| -class TestURLRequest : public net::URLRequest { |
| +class TestURLRequest : public URLRequest { |
| public: |
| TestURLRequest( |
| const GURL& url, Delegate* delegate, TestURLRequestContext* context); |
| @@ -101,7 +103,7 @@ class TestURLRequest : public net::URLRequest { |
| //----------------------------------------------------------------------------- |
| -class TestDelegate : public net::URLRequest::Delegate { |
| +class TestDelegate : public URLRequest::Delegate { |
| public: |
| TestDelegate(); |
| virtual ~TestDelegate(); |
| @@ -117,7 +119,7 @@ class TestDelegate : public net::URLRequest::Delegate { |
| void set_allow_certificate_errors(bool val) { |
| allow_certificate_errors_ = val; |
| } |
| - void set_credentials(const net::AuthCredentials& credentials) { |
| + void set_credentials(const AuthCredentials& credentials) { |
| credentials_ = credentials; |
| } |
| @@ -136,25 +138,25 @@ class TestDelegate : public net::URLRequest::Delegate { |
| } |
| bool auth_required_called() const { return auth_required_; } |
| - // net::URLRequest::Delegate: |
| - virtual void OnReceivedRedirect(net::URLRequest* request, const GURL& new_url, |
| + // URLRequest::Delegate: |
| + virtual void OnReceivedRedirect(URLRequest* request, const GURL& new_url, |
| bool* defer_redirect) OVERRIDE; |
| - virtual void OnAuthRequired(net::URLRequest* request, |
| - net::AuthChallengeInfo* auth_info) OVERRIDE; |
| + virtual void OnAuthRequired(URLRequest* request, |
| + AuthChallengeInfo* auth_info) OVERRIDE; |
| // NOTE: |fatal| causes |certificate_errors_are_fatal_| to be set to true. |
| // (Unit tests use this as a post-condition.) But for policy, this method |
| // consults |allow_certificate_errors_|. |
| - virtual void OnSSLCertificateError(net::URLRequest* request, |
| - const net::SSLInfo& ssl_info, |
| + virtual void OnSSLCertificateError(URLRequest* request, |
| + const SSLInfo& ssl_info, |
| bool fatal) OVERRIDE; |
| - virtual void OnResponseStarted(net::URLRequest* request) OVERRIDE; |
| - virtual void OnReadCompleted(net::URLRequest* request, |
| + virtual void OnResponseStarted(URLRequest* request) OVERRIDE; |
| + virtual void OnReadCompleted(URLRequest* request, |
| int bytes_read) OVERRIDE; |
| private: |
| static const int kBufferSize = 4096; |
| - virtual void OnResponseCompleted(net::URLRequest* request); |
| + virtual void OnResponseCompleted(URLRequest* request); |
| // options for controlling behavior |
| bool cancel_in_rr_; |
| @@ -164,7 +166,7 @@ class TestDelegate : public net::URLRequest::Delegate { |
| bool quit_on_complete_; |
| bool quit_on_redirect_; |
| bool allow_certificate_errors_; |
| - net::AuthCredentials credentials_; |
| + AuthCredentials credentials_; |
| // tracks status of callbacks |
| int response_started_count_; |
| @@ -178,12 +180,12 @@ class TestDelegate : public net::URLRequest::Delegate { |
| std::string data_received_; |
| // our read buffer |
| - scoped_refptr<net::IOBuffer> buf_; |
| + scoped_refptr<IOBuffer> buf_; |
| }; |
| //----------------------------------------------------------------------------- |
| -class TestNetworkDelegate : public net::NetworkDelegate { |
| +class TestNetworkDelegate : public NetworkDelegate { |
| public: |
| enum Options { |
| NO_GET_COOKIES = 1 << 0, |
| @@ -205,48 +207,48 @@ class TestNetworkDelegate : public net::NetworkDelegate { |
| int set_cookie_count() const { return set_cookie_count_; } |
| protected: |
| - // net::NetworkDelegate: |
| - virtual int OnBeforeURLRequest(net::URLRequest* request, |
| - const net::CompletionCallback& callback, |
| + // NetworkDelegate: |
| + virtual int OnBeforeURLRequest(URLRequest* request, |
| + const CompletionCallback& callback, |
| GURL* new_url) OVERRIDE; |
| - virtual int OnBeforeSendHeaders(net::URLRequest* request, |
| - const net::CompletionCallback& callback, |
| - net::HttpRequestHeaders* headers) OVERRIDE; |
| - virtual void OnSendHeaders(net::URLRequest* request, |
| - const net::HttpRequestHeaders& headers) OVERRIDE; |
| + virtual int OnBeforeSendHeaders(URLRequest* request, |
| + const CompletionCallback& callback, |
| + HttpRequestHeaders* headers) OVERRIDE; |
| + virtual void OnSendHeaders(URLRequest* request, |
| + const HttpRequestHeaders& headers) OVERRIDE; |
| virtual int OnHeadersReceived( |
| - net::URLRequest* request, |
| - const net::CompletionCallback& callback, |
| - const net::HttpResponseHeaders* original_response_headers, |
| - scoped_refptr<net::HttpResponseHeaders>* override_response_headers) |
| + URLRequest* request, |
| + const CompletionCallback& callback, |
| + const HttpResponseHeaders* original_response_headers, |
| + scoped_refptr<HttpResponseHeaders>* override_response_headers) |
| OVERRIDE; |
|
wtc
2012/11/12 21:50:49
This may fit on the previous line now.
jochen (gone - plz use gerrit)
2012/11/13 09:17:57
Done.
|
| - virtual void OnBeforeRedirect(net::URLRequest* request, |
| + virtual void OnBeforeRedirect(URLRequest* request, |
| const GURL& new_location) OVERRIDE; |
| - virtual void OnResponseStarted(net::URLRequest* request) OVERRIDE; |
| - virtual void OnRawBytesRead(const net::URLRequest& request, |
| + virtual void OnResponseStarted(URLRequest* request) OVERRIDE; |
| + virtual void OnRawBytesRead(const URLRequest& request, |
| int bytes_read) OVERRIDE; |
| - virtual void OnCompleted(net::URLRequest* request, bool started) OVERRIDE; |
| - virtual void OnURLRequestDestroyed(net::URLRequest* request) OVERRIDE; |
| + virtual void OnCompleted(URLRequest* request, bool started) OVERRIDE; |
| + virtual void OnURLRequestDestroyed(URLRequest* request) OVERRIDE; |
| virtual void OnPACScriptError(int line_number, |
| const string16& error) OVERRIDE; |
| - virtual net::NetworkDelegate::AuthRequiredResponse OnAuthRequired( |
| - net::URLRequest* request, |
| - const net::AuthChallengeInfo& auth_info, |
| + virtual NetworkDelegate::AuthRequiredResponse OnAuthRequired( |
| + URLRequest* request, |
| + const AuthChallengeInfo& auth_info, |
| const AuthCallback& callback, |
| - net::AuthCredentials* credentials) OVERRIDE; |
| - virtual bool OnCanGetCookies(const net::URLRequest& request, |
| - const net::CookieList& cookie_list) OVERRIDE; |
| - virtual bool OnCanSetCookie(const net::URLRequest& request, |
| + AuthCredentials* credentials) OVERRIDE; |
| + virtual bool OnCanGetCookies(const URLRequest& request, |
| + const CookieList& cookie_list) OVERRIDE; |
| + virtual bool OnCanSetCookie(const URLRequest& request, |
| const std::string& cookie_line, |
| - net::CookieOptions* options) OVERRIDE; |
| - virtual bool OnCanAccessFile(const net::URLRequest& request, |
| + CookieOptions* options) OVERRIDE; |
| + virtual bool OnCanAccessFile(const URLRequest& request, |
| const FilePath& path) const OVERRIDE; |
| virtual bool OnCanThrottleRequest( |
| - const net::URLRequest& request) const OVERRIDE; |
| + const URLRequest& request) const OVERRIDE; |
| virtual int OnBeforeSocketStreamConnect( |
| - net::SocketStream* stream, |
| - const net::CompletionCallback& callback) OVERRIDE; |
| - virtual void OnRequestWaitStateChange(const net::URLRequest& request, |
| + SocketStream* stream, |
| + const CompletionCallback& callback) OVERRIDE; |
| + virtual void OnRequestWaitStateChange(const URLRequest& request, |
| RequestWaitState state) OVERRIDE; |
| void InitRequestStatesIfNew(int request_id); |
| @@ -261,7 +263,7 @@ class TestNetworkDelegate : public net::NetworkDelegate { |
| int blocked_set_cookie_count_; |
| int set_cookie_count_; |
| - // net::NetworkDelegate callbacks happen in a particular order (e.g. |
| + // NetworkDelegate callbacks happen in a particular order (e.g. |
| // OnBeforeURLRequest is always called before OnBeforeSendHeaders). |
| // This bit-set indicates for each request id (key) what events may be sent |
| // next. |
| @@ -300,24 +302,26 @@ class ScopedCustomUrlRequestTestHttpHost { |
| //----------------------------------------------------------------------------- |
| // A simple Interceptor that returns a pre-built URLRequestJob only once. |
| -class TestJobInterceptor : public net::URLRequestJobFactory::Interceptor { |
| +class TestJobInterceptor : public URLRequestJobFactory::Interceptor { |
| public: |
| TestJobInterceptor(); |
| - virtual net::URLRequestJob* MaybeIntercept( |
| - net::URLRequest* request, |
| - net::NetworkDelegate* network_delegate) const OVERRIDE; |
| - virtual net::URLRequestJob* MaybeInterceptRedirect( |
| + virtual URLRequestJob* MaybeIntercept( |
| + URLRequest* request, |
| + NetworkDelegate* network_delegate) const OVERRIDE; |
| + virtual URLRequestJob* MaybeInterceptRedirect( |
| const GURL& location, |
| - net::URLRequest* request, |
| - net::NetworkDelegate* network_delegate) const OVERRIDE; |
| - virtual net::URLRequestJob* MaybeInterceptResponse( |
| - net::URLRequest* request, |
| - net::NetworkDelegate* network_delegate) const OVERRIDE; |
| - void set_main_intercept_job(net::URLRequestJob* job); |
| + URLRequest* request, |
| + NetworkDelegate* network_delegate) const OVERRIDE; |
| + virtual URLRequestJob* MaybeInterceptResponse( |
| + URLRequest* request, |
| + NetworkDelegate* network_delegate) const OVERRIDE; |
| + void set_main_intercept_job(URLRequestJob* job); |
| private: |
| - mutable net::URLRequestJob* main_intercept_job_; |
| + mutable URLRequestJob* main_intercept_job_; |
| }; |
| +} // namespace net |
| + |
| #endif // NET_URL_REQUEST_URL_REQUEST_TEST_UTIL_H_ |