Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11369179: Move url_request_test_util into net namespace (Closed)

Created:
8 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
8 years, 1 month ago
CC:
chromium-reviews, pam+watch_chromium.org, michaeln, cbentzel+watch_chromium.org, groby+watch_chromium.org, akalin, shishir+watch_chromium.org, Raghu Simha, jam, joi+watch-content_chromium.org, Aaron Boodman, dominich+watch_chromium.org, darin-cc_chromium.org, tzik+watch_chromium.org, chromium-apps-reviews_chromium.org, gbillock+watch_chromium.org, smckay+watch_chromium.org, haitaol1, rouslan+watch_chromium.org, kinuko+watch, tim (not reviewing)
Visibility:
Public.

Description

Move url_request_test_util into net namespace This file contains some rather generic names like "TestDelegate". Move it to the net namespace to avoid collisions BUG=none TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=167337

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Total comments: 10

Patch Set 4 : patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+361 lines, -343 lines) Patch
M chrome/browser/chromeos/gview_request_interceptor_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/test/component_updater_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc View 1 2 3 6 chunks +22 lines, -21 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_unittest.cc View 5 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_protocols_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/user_script_listener_unittest.cc View 1 2 3 7 chunks +26 lines, -25 lines 0 comments Download
M chrome/browser/intents/cws_intents_registry_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/net/http_pipelining_compatibility_client_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/predictors/resource_prefetcher_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud_interative_uitest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/net/fake_external_tab.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M chrome_frame/test/net/fake_external_tab.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/test_server_test.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/public/test/mock_resource_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/webrtc_audio_device_test.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M jingle/glue/proxy_resolving_client_socket_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M jingle/notifier/base/xmpp_connection_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M jingle/notifier/communicator/single_login_attempt_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M jingle/notifier/listener/push_client_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M jingle/notifier/listener/xmpp_push_client_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/socket_stream/socket_stream_unittest.cc View 1 2 3 23 chunks +55 lines, -55 lines 0 comments Download
M net/url_request/url_request_job_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M net/url_request/url_request_test_util.h View 12 chunks +66 lines, -62 lines 0 comments Download
M net/url_request/url_request_test_util.cc View 22 chunks +81 lines, -78 lines 0 comments Download
M sync/internal_api/http_bridge_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M sync/notifier/invalidator_factory_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M sync/notifier/non_blocking_invalidator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/tools/sync_client.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M sync/tools/sync_listen_notifications.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/appcache/appcache_update_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/file_system_dir_url_request_job_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/fileapi/file_system_url_request_job_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jochen (gone - plz use gerrit)
plz review. i've moved url_request_test_util to namespace net, the rest is just updating all callstites
8 years, 1 month ago (2012-11-11 19:07:34 UTC) #1
willchan no longer on Chromium
net/ LGTM
8 years, 1 month ago (2012-11-12 19:57:05 UTC) #2
wtc
Patch set 3 LGTM. Thanks for cleaning this up. The indentation of some function arguments ...
8 years, 1 month ago (2012-11-12 21:50:49 UTC) #3
jochen (gone - plz use gerrit)
https://codereview.chromium.org/11369179/diff/5038/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc File chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc (right): https://codereview.chromium.org/11369179/diff/5038/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc#newcode158 chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc:158: NULL, &context); On 2012/11/12 21:50:49, wtc wrote: > > ...
8 years, 1 month ago (2012-11-13 09:17:57 UTC) #4
jochen (gone - plz use gerrit)
TBR'ing darin for all the additions of net::
8 years, 1 month ago (2012-11-13 09:19:02 UTC) #5
wtc
Patch set 4 LGTM. Thanks.
8 years, 1 month ago (2012-11-13 16:06:35 UTC) #6
akalin
sync lgtm
8 years, 1 month ago (2012-11-13 16:34:46 UTC) #7
darin (slow to review)
8 years, 1 month ago (2012-11-14 07:25:41 UTC) #8 
LGTM

Powered by Google App Engine
This is Rietveld 408576698