Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: tests/language/factory_type_parameter_test.dart

Issue 11369168: Fix result type checking of factory constructors of generic classes in VM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/language/factory_redirection_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/factory_type_parameter_test.dart
===================================================================
--- tests/language/factory_type_parameter_test.dart (revision 14760)
+++ tests/language/factory_type_parameter_test.dart (working copy)
@@ -4,7 +4,7 @@
class A<T> {
factory A.factory() {
- return new B<Set>();
+ return new B<T>();
}
A();
@@ -24,18 +24,18 @@
main() {
Expect.isTrue(new A<List>() is A<List>);
- Expect.isTrue(new A<List>.factory() is B<Set>);
+ Expect.isTrue(new A<List>.factory() is B<List>);
// Check that we don't always return true for is checks with
// generics.
Expect.isFalse(new A<List>() is A<Set>);
- Expect.isFalse(new A<List>.factory() is B<List>);
+ Expect.isFalse(new A<List>.factory() is B<Set>);
Expect.isTrue(new A<List>().build() is A<List>);
Expect.isFalse(new A<List>().build() is A<Set>);
- Expect.isTrue(new A<List>.factory().build() is B<Set>);
- Expect.isFalse(new A<List>.factory().build() is B<List>);
+ Expect.isTrue(new A<List>.factory().build() is B<List>);
+ Expect.isFalse(new A<List>.factory().build() is B<Set>);
Expect.isTrue(new B<List>().build() is B<List>);
Expect.isFalse(new B<List>().build() is B<Set>);
« no previous file with comments | « tests/language/factory_redirection_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698