Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: runtime/vm/parser.cc

Issue 11369168: Fix result type checking of factory constructors of generic classes in VM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/class_finalizer.cc ('k') | tests/language/factory1_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc (revision 14760)
+++ runtime/vm/parser.cc (working copy)
@@ -3017,6 +3017,11 @@
if (IsIdentifier() &&
(CurrentLiteral()->Equals(members->class_name()) || member.has_factory)) {
if (member.has_factory) {
+ // TODO(regis): Simplify this code once the core library is fixed.
+ // See issue 6641.
+ // Per specification, the name of the factory must be the name of the
+ // immediately enclosing class.
+
// The factory name may be qualified.
QualIdent factory_name;
ParseQualIdent(&factory_name);
« no previous file with comments | « runtime/vm/class_finalizer.cc ('k') | tests/language/factory1_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698