Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 11369151: Minimal implementation and tests of observable array methods (Closed)

Created:
8 years, 1 month ago by adamk
Modified:
8 years, 1 month ago
Reviewers:
rossberg
CC:
v8-dev, rafaelw
Visibility:
Public.

Description

Minimal implementation and tests of observable array methods Bail out of any special-casing in array methods. Further optimization is possible, but can be left for later. Committed: https://code.google.com/p/v8/source/detail?r=12917

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -9 lines) Patch
M src/array.js View 5 chunks +7 lines, -4 lines 1 comment Download
M src/builtins.cc View 6 chunks +22 lines, -4 lines 0 comments Download
M test/mjsunit/harmony/object-observe.js View 2 chunks +144 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
adamk
https://codereview.chromium.org/11369151/diff/1/src/array.js File src/array.js (right): https://codereview.chromium.org/11369151/diff/1/src/array.js#newcode444 src/array.js:444: delete this[n]; This change is required for proper operation, ...
8 years, 1 month ago (2012-11-09 12:06:30 UTC) #1
rossberg
8 years, 1 month ago (2012-11-09 12:21:51 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698