Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 11369150: Add more test coverage for setting Array.length (Closed)

Created:
8 years, 1 month ago by adamk
Modified:
8 years, 1 month ago
Reviewers:
rossberg
CC:
v8-dev, rafaelw
Visibility:
Public.

Description

Add more test coverage for setting Array.length Covers truncation of holey arrays and defineProperty('length'). Committed: https://code.google.com/p/v8/source/detail?r=12915

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M test/mjsunit/harmony/object-observe.js View 3 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
adamk
8 years, 1 month ago (2012-11-09 10:08:12 UTC) #1
rossberg
8 years, 1 month ago (2012-11-09 10:48:27 UTC) #2
LGTM, landing.

Powered by Google App Engine
This is Rietveld 408576698