Implement {Start,Stop}CapturingKeyStrokes for Instant.

chrome/renderer/searchbox/searchbox_extension.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/searchbox/searchbox_extension.h"
 
 #include "base/string_number_conversions.h"
 #include "base/stringprintf.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/renderer/searchbox/searchbox.h"
@@ skipping 230 matching lines @@
   // Sets the search box text, completely replacing what the user typed.
   static v8::Handle<v8::Value> SetQuery(const v8::Arguments& args);
 
   // Like |SetQuery| but uses a restricted ID to identify the text.
   static v8::Handle<v8::Value> SetQueryFromAutocompleteResult(
       const v8::Arguments& args);
 
   // Requests the preview be shown with the specified contents and height.
   static v8::Handle<v8::Value> Show(const v8::Arguments& args);
 
+  // Start capturing user key strokes.
+  static v8::Handle<v8::Value> StartCapturingKeyStrokes(
+      const v8::Arguments& args);
+
+  // Stop capturing user key strokes.
+  static v8::Handle<v8::Value> StopCapturingKeyStrokes(
+      const v8::Arguments& args);
+
  private:
   DISALLOW_COPY_AND_ASSIGN(SearchBoxExtensionWrapper);
 };
 
 SearchBoxExtensionWrapper::SearchBoxExtensionWrapper(
     const base::StringPiece& code)
     : v8::Extension(kSearchBoxExtensionName, code.data(), 0, 0, code.size()) {
 }
 
 v8::Handle<v8::FunctionTemplate> SearchBoxExtensionWrapper::GetNativeFunction(
@@ skipping 31 matching lines @@
   if (name->Equals(v8::String::New("SetQuerySuggestion")))
     return v8::FunctionTemplate::New(SetQuerySuggestion);
   if (name->Equals(v8::String::New("SetQuerySuggestionFromAutocompleteResult")))
     return v8::FunctionTemplate::New(SetQuerySuggestionFromAutocompleteResult);
   if (name->Equals(v8::String::New("SetQuery")))
     return v8::FunctionTemplate::New(SetQuery);
   if (name->Equals(v8::String::New("SetQueryFromAutocompleteResult")))
     return v8::FunctionTemplate::New(SetQueryFromAutocompleteResult);
   if (name->Equals(v8::String::New("Show")))
     return v8::FunctionTemplate::New(Show);
+  if (name->Equals(v8::String::New("StartCapturingKeyStrokes")))
+    return v8::FunctionTemplate::New(StartCapturingKeyStrokes);
+  if (name->Equals(v8::String::New("StopCapturingKeyStrokes")))
+    return v8::FunctionTemplate::New(StopCapturingKeyStrokes);
   return v8::Handle<v8::FunctionTemplate>();
 }
 
 // static
 content::RenderView* SearchBoxExtensionWrapper::GetRenderView() {
   WebKit::WebFrame* webframe = WebKit::WebFrame::frameForCurrentContext();
   if (!webframe) return NULL;
 
   WebKit::WebView* webview = webframe->view();
   if (!webview) return NULL;  // can happen during closing
@@ skipping 419 matching lines @@
     height = args[1]->Int32Value();
     units = INSTANT_SIZE_PIXELS;
   }
 
   SearchBox::Get(render_view)->ShowInstantPreview(reason, height, units);
 
   return v8::Undefined();
 }
 
 // static
+v8::Handle<v8::Value> SearchBoxExtensionWrapper::StartCapturingKeyStrokes(
+    const v8::Arguments& args) {
+  content::RenderView* render_view = GetRenderView();
+  if (render_view)

[sreeram, 2012/12/04 21:54:58]

Perhaps follow the existing style (here and in the other method below):

if (!render_view) return v8::Undefined();

DVLOG(1) << render_view << " StartCapturingKeyStrokes";
SearchBox::Get(...)->...;
return v8::Undefined();

[samarth, 2012/12/04 22:13:43]

Done.

+    SearchBox::Get(render_view)->StartCapturingKeyStrokes();
+  return v8::Undefined();
+}
+
+// static
+v8::Handle<v8::Value> SearchBoxExtensionWrapper::StopCapturingKeyStrokes(
+    const v8::Arguments& args) {
+  content::RenderView* render_view = GetRenderView();
+  if (render_view)
+    SearchBox::Get(render_view)->StopCapturingKeyStrokes();
+  return v8::Undefined();
+}
+
+// static
 void SearchBoxExtension::DispatchChange(WebKit::WebFrame* frame) {
   Dispatch(frame, kDispatchChangeEventScript);
 }
 
 // static
 void SearchBoxExtension::DispatchSubmit(WebKit::WebFrame* frame) {
   Dispatch(frame, kDispatchSubmitEventScript);
 }
 
 // static
@@ skipping 44 matching lines @@
   Dispatch(frame, kDispatchThemeAreaHeightChangeEventScript);
 }
 
 // static
 v8::Extension* SearchBoxExtension::Get() {
   return new SearchBoxExtensionWrapper(ResourceBundle::GetSharedInstance().
       GetRawDataResource(IDR_SEARCHBOX_API));
 }
 
 }  // namespace extensions_v8