Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 11369131: Implement MarkIndependent(Isolate*) and MarkPartiallyDependent(Isolate*) (Closed)

Created:
8 years, 1 month ago by haraken
Modified:
8 years, 1 month ago
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Implement MarkIndependent(Isolate*) and MarkPartiallyDependent(Isolate*) BUG= TEST=cctest/test-api/IndependentWeakHandle Committed: https://code.google.com/p/v8/source/detail?r=12904

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -9 lines) Patch
M include/v8.h View 4 chunks +18 lines, -0 lines 0 comments Download
M src/api.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +15 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
haraken
This will probably be a final patch for passing Isolate to V8 APIs that are ...
8 years, 1 month ago (2012-11-08 10:02:01 UTC) #1
Michael Starzinger
LGTM. I'll land this for you. As discussed offline, it should be possible to make ...
8 years, 1 month ago (2012-11-08 14:55:35 UTC) #2
haraken
8 years, 1 month ago (2012-11-08 14:57:26 UTC) #3
Yes, the idea sounds good. I will upload patches in the near future. Thanks!

On 2012/11/08 14:55:35, Michael Starzinger wrote:
> LGTM. I'll land this for you.
> 
> As discussed offline, it should be possible to make these two functions (and
> others that only check predicates) completely inlineable. If these functions
are
> on a hot path, it might be worth considering that.

Powered by Google App Engine
This is Rietveld 408576698