Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart

Issue 1136913006: dart2js: remove JS_OBJECT_CLASS_NAME and JS_NULL_CLASS_NAME from foreign (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove empty lines. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart ('k') | pkg/compiler/lib/src/ssa/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
index dd2c214d749f956ddbcd98accd490c3fe046f230..310a243edbd8b04a87c8333a4672b709c59d4e19 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
@@ -283,12 +283,6 @@ class OldEmitter implements Emitter {
case JsBuiltin.isFunctionType:
return backend.rti.representationGenerator.templateForIsFunctionType;
- case JsBuiltin.isFunctionTypeLiteral:
- String functionClassName =
- backend.namer.runtimeTypeName(compiler.functionClass);
- return jsAst.js.expressionTemplateFor(
- '#.$typeNameProperty === "$functionClassName"');
-
case JsBuiltin.typeName:
return jsAst.js.expressionTemplateFor("#.$typeNameProperty");
@@ -306,6 +300,24 @@ class OldEmitter implements Emitter {
return jsAst.js.expressionTemplateFor(
"('$isPrefix' + #) in #.prototype");
+ case JsBuiltin.isFunctionTypeRti:
+ String functionClassName =
+ backend.namer.runtimeTypeName(compiler.functionClass);
+ return jsAst.js.expressionTemplateFor(
+ '#.$typeNameProperty === "$functionClassName"');
+
+ case JsBuiltin.isDartObjectTypeRti:
+ String objectClassName =
+ backend.namer.runtimeTypeName(compiler.objectClass);
+ return jsAst.js.expressionTemplateFor(
+ '#.$typeNameProperty === "$objectClassName"');
+
+ case JsBuiltin.isNullTypeRti:
+ String nullClassName =
+ backend.namer.runtimeTypeName(compiler.nullClass);
+ return jsAst.js.expressionTemplateFor(
+ '#.$typeNameProperty === "$nullClassName"');
+
case JsBuiltin.getMetadata:
String metadataAccess =
generateEmbeddedGlobalAccessString(embeddedNames.METADATA);
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart ('k') | pkg/compiler/lib/src/ssa/builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698