content/test/gpu/gpu_tests/pixel_expectations.py - Issue 1136913005: Compute the base dpi from X

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/gpu/gpu_tests/pixel_expectations.py

Issue 1136913005: Compute the base dpi from X (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mark the tests whose expectations need to be updated failing Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from gpu_test_expectations import GpuTestExpectations	5 from gpu_test_expectations import GpuTestExpectations

6	6

7 # See the GpuTestExpectations class for documentation.	7 # See the GpuTestExpectations class for documentation.

8	8

9 class PixelExpectations(GpuTestExpectations):	9 class PixelExpectations(GpuTestExpectations):

10 def SetExpectations(self):	10 def SetExpectations(self):

11 # Sample Usage:	11 # Sample Usage:

12 # self.Fail('Pixel.Canvas2DRedBox',	12 # self.Fail('Pixel.Canvas2DRedBox',

13 # ['mac', 'amd', ('nvidia', 0x1234)], bug=123)	13 # ['mac', 'amd', ('nvidia', 0x1234)], bug=123)

	14 self.Fail('Pixel.Canvas2DRedBox',

	15 [ ('nvidia', 0x104a)], bug=485183)

	16 self.Fail('Pixel.CSS3DBlueBox',

	17 [ ('nvidia', 0x104a)], bug=485183)

	18 self.Fail('Pixel.WebGLGreenTriangle',

	19 [ ('nvidia', 0x104a)], bug=485183)
	Ken Russell (switch to Gerrit) 2015/05/15 18:18:56 Actually, since you need to update the revision nu Actually, since you need to update the revision number of all of these tests, you'll have to mark them failing for all platforms. In this CL, please also increment the version numbers for all of these tets in src/content/test/gpu/page_sets/pixel_tests.py . We need to keep the duration of how long these are marked failing as short as possible. Once this is in the CQ, please prepare and send for review another CL which un-marks these as failing. oshima 2015/05/15 19:37:18 Done. Show quoted text On 2015/05/15 18:18:56, Ken Russell wrote: > Actually, since you need to update the revision number of all of these tests, > you'll have to mark them failing for all platforms. In this CL, please also > increment the version numbers for all of these tets in > src/content/test/gpu/page_sets/pixel_tests.py . > > We need to keep the duration of how long these are marked failing as short as > possible. Once this is in the CQ, please prepare and send for review another CL > which un-marks these as failing. Done.
14 pass	20 pass
	Ken Russell (switch to Gerrit) 2015/05/15 18:18:56 I think you may need to remove this "pass". Did yo I think you may need to remove this "pass". Did you try running the tests with this patch? https://www.chromium.org/developers/testing/gpu-testing#TOC-Running-the-GPU-T... If it runs OK then no need to remove it. oshima 2015/05/15 19:37:18 Done. Show quoted text On 2015/05/15 18:18:56, Ken Russell wrote: > I think you may need to remove this "pass". Did you try running the tests with > this patch? > https://www.chromium.org/developers/testing/gpu-testing#TOC-Running-the-GPU-T... > > If it runs OK then no need to remove it. Done.
OLD	NEW

« no previous file with comments | « chrome/browser/ui/libgtk2ui/gtk2_ui.cc ('k') | no next file » | no next file with comments »