Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: utils/apidoc/apidoc.dart

Issue 11369074: Handle (missing) trailing slash in dartdoc (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: utils/apidoc/apidoc.dart
diff --git a/utils/apidoc/apidoc.dart b/utils/apidoc/apidoc.dart
index bbd2f58a6fdd949c9b99cd644f21dfd49c9c03ee..fe12e4ee7185b48b99a2b10a83c3df11c275cbbb 100644
--- a/utils/apidoc/apidoc.dart
+++ b/utils/apidoc/apidoc.dart
@@ -64,7 +64,7 @@ void main() {
}
}
- final libPath = doc.scriptDir.append('../../sdk/lib');
+ final libPath = doc.scriptDir.append('../../sdk/');
final pkgPath = doc.scriptDir.append('../../pkg/');
doc.cleanOutputDirectory(outputDir);
@@ -553,7 +553,7 @@ class Apidoc extends doc.Dartdoc {
String _linkMember(MemberMirror member) {
final typeName = member.owner.simpleName;
var memberName = '$typeName.${member.simpleName}';
- if (member is MethodMirror && (member.isConstructor || member.isFactory)) {
Johnni Winther 2012/11/05 13:42:50 Dead code (and a resolution error - it's now calle
ahe 2012/11/05 15:58:42 What is dead code, and what is a resolution error?
Johnni Winther 2012/11/05 16:23:29 The isFactory method has been renamed to isFactory
ahe 2012/11/05 16:46:08 Terminology by example: if (false) { print('Thi
+ if (member is MethodMirror && member.isConstructor) {
final separator = member.constructorName == '' ? '' : '.';
memberName = 'new $typeName$separator${member.constructorName}';
}
« sdk/lib/_internal/compiler/implementation/apiimpl.dart ('K') | « tools/create_sdk.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698