Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2992)

Unified Diff: chrome/renderer/resources/extensions/app_window_custom_bindings.js

Issue 11369039: Add setBounds method and browsertest for get/set bounds to app window API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/app_window_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/app_window_custom_bindings.js b/chrome/renderer/resources/extensions/app_window_custom_bindings.js
index d087c72f15889772107555e42e18222e662907dd..9d38b6ddb988254211b02456a0447ef9a10722a0 100644
--- a/chrome/renderer/resources/extensions/app_window_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/app_window_custom_bindings.js
@@ -23,7 +23,7 @@ chromeHidden.registerCustomHook('app.window', function(bindingsAPI) {
// No route to created window. If given a callback, trigger it with an
// undefined object.
if (request.callback) {
- request.callback()
+ request.callback();
delete request.callback;
}
return;
@@ -69,7 +69,7 @@ chromeHidden.registerCustomHook('app.window', function(bindingsAPI) {
};
// This is an internal function, but needs to be bound with setHandleRequest
- // because it is called from a different JS context
+ // because it is called from a different JS context.
apiFunctions.setHandleRequest('initializeAppWindow', function(params) {
var AppWindow = function() {};
forEach(chromeHidden.internalAPIs.app.currentWindowInternal, function(fn) {
@@ -95,7 +95,8 @@ chromeHidden.registerCustomHook('app.window', function(bindingsAPI) {
chromeHidden.appWindowData = {
id: params.id || '',
- bounds: { left: 0, top: 0, width: 0, height: 0 }
+ bounds: { left: params.bounds.left, top: params.bounds.top,
+ width: params.bounds.width, height: params.bounds.height }
};
chromeHidden.currentAppWindow = new AppWindow;
});

Powered by Google App Engine
This is Rietveld 408576698