Update Compile Step to Build Swarm Targets if Needed

scripts/master/factory/swarm_commands.py

Index: scripts/master/factory/swarm_commands.py
diff --git a/scripts/master/factory/swarm_commands.py b/scripts/master/factory/swarm_commands.py
index f36bedec866f57474be7389cb422d758f1517b33..eab624ce8b94e18cb9e04bde43d34b05243ed69e 100644
--- a/scripts/master/factory/swarm_commands.py
+++ b/scripts/master/factory/swarm_commands.py
@@ -20,18 +20,11 @@ def TestStepFilterSwarm(bStep):
   build has swarm steps and thus if the test should run.
   It also adds a property, swarm_tests, which contains all the tests which will
   run under swarm."""
-  bStep.setProperty('swarm_tests', '')
   test_filters = bStep.build.getProperties().getProperty('testfilter')
   test_filters = test_filters or commands.DEFAULT_TESTS
 
-  swarm_tests = ''
-  for test_filter in test_filters:
-    if '_swarm:' in test_filter:
-      swarm_tests += test_filter.split('_swarm:')[0] + ' '
-    elif test_filter.endswith('_swarm'):
-      swarm_tests += test_filter[:-len('_swarm')] + ' '
-
-  bStep.setProperty('swarm_tests', swarm_tests.strip())
+  swarm_tests = commands.GetSwarmTestsFromTestFilter(test_filters)
+  bStep.setProperty('swarm_tests', ' '.join(swarm_tests))

[M-A Ruel, 2012/11/01 20:00:00]

Why not keep it as a list?

I see it was a string before so while I'm asking here, it's outside the scope of
this CL, but conceptually it would have been better.

[csharp, 2012/11/01 20:05:25]

I think I converted to a string because I didn't think any other values were
allowed (the testfilter getting converted to a string convinced me). Added a
TODO

 
   return bool(swarm_tests)