Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1136893003: [Do not revert] Roll-back V8 to version 4.4.63. (Closed)

Created:
5 years, 7 months ago by Michael Hablich
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Do not revert] Roll-back V8 to version 4.4.63. Update the V8 version to the one used for the upcoming Chromium branch M44. If this CL results in failed tests please contact the test owners. They most likely need to make changes to deal with the roll-back. Original roll: https://crrev.com/1224d1ad48f94177798158fdc0e3e7faed8635ab When in doubt please try to contact the committer. TBR=machenbach@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,danno@chromium.org Committed: https://crrev.com/bded78c5584554bba382b4f89e3269179a755d35 Cr-Commit-Position: refs/heads/master@{#329629}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (1 generated)
Michael Hablich
5 years, 7 months ago (2015-05-13 12:12:45 UTC) #1
Michael Hablich
5 years, 7 months ago (2015-05-13 12:15:46 UTC) #2
Michael Achenbach
Please make the description a bit less wordy. It's also chromium policy to manually format ...
5 years, 7 months ago (2015-05-13 12:22:03 UTC) #3
Michael Achenbach
Maybe call the CL: Reset V8 to version 4.4.63. This is self-explanatory and most people ...
5 years, 7 months ago (2015-05-13 12:25:41 UTC) #4
Michael Hablich
On 2015/05/13 12:25:41, Michael Achenbach wrote: > Maybe call the CL: > Reset V8 to ...
5 years, 7 months ago (2015-05-13 12:29:20 UTC) #5
Michael Hablich
On 2015/05/13 12:29:20, Hablich wrote: > On 2015/05/13 12:25:41, Michael Achenbach wrote: > > Maybe ...
5 years, 7 months ago (2015-05-13 12:33:36 UTC) #6
Michael Achenbach
On 2015/05/13 12:29:20, Hablich wrote: > On 2015/05/13 12:25:41, Michael Achenbach wrote: > > Maybe ...
5 years, 7 months ago (2015-05-13 12:38:31 UTC) #7
Michael Achenbach
lgtm
5 years, 7 months ago (2015-05-13 12:44:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136893003/1
5 years, 7 months ago (2015-05-13 12:48:04 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 13:54:06 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 13:54:58 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bded78c5584554bba382b4f89e3269179a755d35
Cr-Commit-Position: refs/heads/master@{#329629}

Powered by Google App Engine
This is Rietveld 408576698