Move V4L2 code into a webcam helper class.

Move V4L2 code into a webcam helper class.

This will make it simpler to add new webcam interface types.

BUG=None

Committed: https://crrev.com/6c3c6032ca10259fcc749cc7da3ea20629dcb85b
Cr-Commit-Position: refs/heads/master@{#329922}

[Zachary Kuznia, 2015-05-13 23:50:42]

zork@chromium.org changed reviewers:
+ rockot@chromium.org

[Zachary Kuznia, 2015-05-13 23:50:43]

Hi Ken,

Please take a look.

Thanks,
-Zach

[Ken Rockot(use gerrit already), 2015-05-14 00:07:02]

You want to also ensure your service factory is available at runtime!

Check out extensions/browser/browser_context_keyed_service_factories.cc and it
should be pretty obvious what to do there.

https://codereview.chromium.org/1136883004/diff/20001/extensions/browser/api/...
File extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc
(right):

https://codereview.chromium.org/1136883004/diff/20001/extensions/browser/api/...
extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc:236: }
You also need to declare your dependency on ProcessManager since it too is a
keyed service. Something like:

template <>
void BrowserContextedKeyedAPIFactory<WebcamPrivateAPI>
    ::DeclareFactoryDependencies() {
  DependsOn(ExtensionsBrowserClient::Get()->GetExtensionSystemFactory());
  DependsOn(ProcessManagerFactory::GetInstance());
}

should be sufficient.

[Zachary Kuznia, 2015-05-14 17:25:11]

Done

https://codereview.chromium.org/1136883004/diff/20001/extensions/browser/api/...
File extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc
(right):

https://codereview.chromium.org/1136883004/diff/20001/extensions/browser/api/...
extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc:236: }
On 2015/05/14 00:07:02, Ken Rockot wrote:
> You also need to declare your dependency on ProcessManager since it too is a
> keyed service. Something like:
> 
> template <>
> void BrowserContextedKeyedAPIFactory<WebcamPrivateAPI>
>     ::DeclareFactoryDependencies() {
>   DependsOn(ExtensionsBrowserClient::Get()->GetExtensionSystemFactory());
>   DependsOn(ProcessManagerFactory::GetInstance());
> }
> 
> should be sufficient.

Done.

[Ken Rockot(use gerrit already), 2015-05-14 19:02:07]

lgtm

[Zachary Kuznia, 2015-05-14 19:38:09]

The CQ bit was checked by zork@chromium.org

[Zachary Kuznia, 2015-05-14 19:38:09]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/1136883004/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2015-05-14 19:39:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1136883004/60001

[commit-bot: I haz the power, 2015-05-14 20:39:38]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-05-14 20:40:16]

Patchset 4 (id:??) landed as
https://crrev.com/6c3c6032ca10259fcc749cc7da3ea20629dcb85b
Cr-Commit-Position: refs/heads/master@{#329922}