Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1136883003: Expose Document::isPrivilegedContext from WebDocument (Closed)

Created:
5 years, 7 months ago by raymes
Modified:
5 years, 7 months ago
Reviewers:
jww, dcheng
CC:
dcheng, blink-reviews, chrome-apps-syd-reviews_chromium.org, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Expose Document::isPrivilegedContext from WebDocument This exposes the isPrivilegedContext function in the public blink API. BUG=472256 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195294

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -11 lines) Patch
M Source/core/dom/Document.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ExecutionContext.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/testing/NullExecutionContext.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/testing/NullExecutionContext.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerGlobalScope.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebDocument.cpp View 1 1 chunk +11 lines, -0 lines 0 comments Download
M public/web/WebDocument.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
jww
lgtm https://codereview.chromium.org/1136883003/diff/1/Source/web/WebDocument.cpp File Source/web/WebDocument.cpp (right): https://codereview.chromium.org/1136883003/diff/1/Source/web/WebDocument.cpp#newcode87 Source/web/WebDocument.cpp:87: Document* document = unwrap<Document>(); I *think* isPrivilegedContext() actually ...
5 years, 7 months ago (2015-05-12 02:35:21 UTC) #2
raymes
Done, I made it const :) +dcheng
5 years, 7 months ago (2015-05-12 06:15:59 UTC) #4
jww
On 2015/05/12 06:15:59, raymes wrote: > Done, I made it const :) > > +dcheng ...
5 years, 7 months ago (2015-05-12 06:17:02 UTC) #5
dcheng
lgtm
5 years, 7 months ago (2015-05-13 00:46:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136883003/20001
5 years, 7 months ago (2015-05-13 00:48:23 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 04:19:09 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195294

Powered by Google App Engine
This is Rietveld 408576698