|
|
Created:
5 years, 7 months ago by Jakub Gieryluk Modified:
5 years, 5 months ago CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/blink.git@master Target Ref:
refs/heads/master Project:
blink Visibility:
Public. |
DescriptionDevTools: display 2 versions of "Copy as cURL" in Network panel on Windows
"Copy as cURL" command in Network panel produces an output that
is platform-dependent: escapings are different for cmd and posix
However many Windows user use unixy shell (for instance msys / git bash)
and hence it makes sense to expose them a unixy curl command.
BUG=488371
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198003
Patch Set 1 #
Total comments: 1
Patch Set 2 : Changed == to === and rebased #Patch Set 3 : Removed trailing whitespace #Messages
Total messages: 20 (7 generated)
Looking forward to the comments!
I opened bug 488371 for tracking the issue itself, in separation from the code review https://code.google.com/p/chromium/issues/detail?id=488371
paulirish@chromium.org changed reviewers: + alph@chromium.org, paulirish@chromium.org
alph, can you take a look?
Thanks for fixing it. lgtm with a comment. https://codereview.chromium.org/1136843010/diff/1/Source/devtools/front_end/n... File Source/devtools/front_end/network/NetworkLogView.js (right): https://codereview.chromium.org/1136843010/diff/1/Source/devtools/front_end/n... Source/devtools/front_end/network/NetworkLogView.js:1778: var escapeString = platform == "win" ? escapeStringWin : escapeStringPosix; please use === for comparison.
Jakub, can you add an extra = and `git cl upload` a new patchset? Thx!
The CQ bit was checked by alph@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136843010/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/3...)
Hi, thanks for looking into this, just updated the patch with `==` to `===` change FYI I had a fatal error while trying to submit the changed patch (didn't happen the first time); googling / updating blink and depot_tools didn't help, so I resorted to manually disabling presubmit check in `presubmit_support` to get it through ``` $ git cl upload Using 50% similarity for rename/copy detection. Override with --similarity. Running presubmit upload checks ... Traceback (most recent call last): File "d:\gh\depot_tools\git_cl.py", line 3400, in <module> sys.exit(main(sys.argv[1:])) File "d:\gh\depot_tools\git_cl.py", line 3382, in main return dispatcher.execute(OptionParser(), argv) File "d:\gh\depot_tools\subcommand.py", line 252, in execute return command(parser, args[1:]) File "d:\gh\depot_tools\git_cl.py", line 2229, in CMDupload change=change) File "d:\gh\depot_tools\git_cl.py", line 1078, in RunHook rietveld_obj=self.RpcServer()) File "d:\gh\depot_tools\presubmit_support.py", line 1471, in DoPresubmitChecks results += executer.ExecPresubmitScript(presubmit_script, filename) File "d:\gh\depot_tools\presubmit_support.py", line 1388, in ExecPresubmitScript result = eval(function_name + '(*__args)', context) File "<string>", line 1, in <module> File "<string>", line 326, in CheckChangeOnUpload File "<string>", line 81, in _CommonChecks File "<string>", line 193, in _CheckUnwantedDependencies ImportError: No module named checkdeps ```
The CQ bit was checked by alph@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org Link to the patchset: https://codereview.chromium.org/1136843010/#ps40001 (title: "Removed trailing whitespace")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136843010/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/66413)
On 2015/06/12 12:09:25, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > win_blink_rel on tryserver.blink (JOB_FAILED, > http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/66413) Jakub, looks like you need to update inspector/curl-command.html test.
The CQ bit was checked by alph@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136843010/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=198003 |