Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1136843010: DevTools: display 2 versions of "Copy as cURL" in Network panel on Windows (Closed)

Created:
5 years, 7 months ago by Jakub Gieryluk
Modified:
5 years, 5 months ago
Reviewers:
paulirish, alph
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: display 2 versions of "Copy as cURL" in Network panel on Windows "Copy as cURL" command in Network panel produces an output that is platform-dependent: escapings are different for cmd and posix However many Windows user use unixy shell (for instance msys / git bash) and hence it makes sense to expose them a unixy curl command. BUG=488371 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198003

Patch Set 1 #

Total comments: 1

Patch Set 2 : Changed == to === and rebased #

Patch Set 3 : Removed trailing whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M Source/devtools/front_end/network/NetworkLogView.js View 1 2 4 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
Jakub Gieryluk
Looking forward to the comments!
5 years, 7 months ago (2015-05-15 08:33:50 UTC) #1
Jakub Gieryluk
I opened bug 488371 for tracking the issue itself, in separation from the code review ...
5 years, 7 months ago (2015-05-15 08:50:12 UTC) #2
paulirish
alph, can you take a look?
5 years, 6 months ago (2015-06-03 18:06:41 UTC) #4
alph
Thanks for fixing it. lgtm with a comment. https://codereview.chromium.org/1136843010/diff/1/Source/devtools/front_end/network/NetworkLogView.js File Source/devtools/front_end/network/NetworkLogView.js (right): https://codereview.chromium.org/1136843010/diff/1/Source/devtools/front_end/network/NetworkLogView.js#newcode1778 Source/devtools/front_end/network/NetworkLogView.js:1778: var ...
5 years, 6 months ago (2015-06-03 19:01:17 UTC) #5
paulirish
Jakub, can you add an extra = and `git cl upload` a new patchset? Thx!
5 years, 6 months ago (2015-06-09 18:13:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136843010/1
5 years, 6 months ago (2015-06-11 13:33:14 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/35168)
5 years, 6 months ago (2015-06-11 13:38:14 UTC) #10
Jakub Gieryluk
Hi, thanks for looking into this, just updated the patch with `==` to `===` change ...
5 years, 6 months ago (2015-06-12 07:04:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136843010/40001
5 years, 6 months ago (2015-06-12 10:06:29 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/66413)
5 years, 6 months ago (2015-06-12 12:09:25 UTC) #16
alph
On 2015/06/12 12:09:25, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 6 months ago (2015-06-12 18:30:13 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136843010/40001
5 years, 5 months ago (2015-06-29 15:17:53 UTC) #19
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 17:16:09 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198003

Powered by Google App Engine
This is Rietveld 408576698