Remove --enable-firewall-hole-punching flag, default to enabled.

Remove --enable-firewall-hole-punching flag, default to enabled.

Enable firewall hole punching for Chrome Apps by taking this feature out
from behind a flag.

BUG=478231
Committed: https://crrev.com/335730eaff11508dcf50445ec9db2812a2a31360
Cr-Commit-Position: refs/heads/master@{#329959}

[Reilly Grant (use Gerrit), 2015-05-14 01:17:49]

reillyg@chromium.org changed reviewers:
+ mpearson@chromium.org

[Reilly Grant (use Gerrit), 2015-05-14 01:18:02]

Mark P for histograms.xml changes.

[Reilly Grant (use Gerrit), 2015-05-14 01:18:26]

reillyg@chromium.org changed reviewers:
+ rpaquay@chromium.org

[Reilly Grant (use Gerrit), 2015-05-14 01:18:45]

Renaud, please take a look at this patch.

[rpaquay, 2015-05-14 03:14:07]

lgtm

[Reilly Grant (use Gerrit), 2015-05-14 20:47:44]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2015-05-14 20:47:51]

The CQ bit was unchecked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2015-05-14 21:04:55]

Ping for histograms changes.

[Mark P, 2015-05-14 21:31:55]

histograms.xml NOT lgtm.

Please do not delete values.  They aid interpretation of old logs.

--mark

[Reilly Grant (use Gerrit), 2015-05-14 21:35:50]

On 2015/05/14 21:31:55, Mark P wrote:
> histograms.xml NOT lgtm.
> 
> Please do not delete values.  They aid interpretation of old logs.
> 
> --mark

Thanks.

[Reilly Grant (use Gerrit), 2015-05-14 21:36:21]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2015-05-14 21:36:21]

The patchset sent to the CQ was uploaded after l-g-t-m from rpaquay@chromium.org
Link to the patchset: https://codereview.chromium.org/1136843008/#ps20001
(title: "Revert histograms.xml change.")

[commit-bot: I haz the power, 2015-05-14 21:37:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1136843008/20001

[commit-bot: I haz the power, 2015-05-14 21:37:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-14 21:37:31]

A disapproval has been posted by following reviewers: mpearson@chromium.org.
Please make sure to get positive review before another CQ attempt.

[Mark P, 2015-05-14 21:39:51]

Now this change is lgtm from a metrics point of view.

--mark

[Reilly Grant (use Gerrit), 2015-05-14 21:41:04]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2015-05-14 21:42:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1136843008/20001

[commit-bot: I haz the power, 2015-05-14 22:38:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-14 22:39:35]

Patchset 2 (id:??) landed as
https://crrev.com/335730eaff11508dcf50445ec9db2812a2a31360
Cr-Commit-Position: refs/heads/master@{#329959}