Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart

Issue 1136843006: dart2js cps: Access to lazily initialized fields. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart ('k') | tests/co19/co19-dart2js.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart
diff --git a/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart b/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart
index 109dc42a284e14a8e1dcb74ad76f9bf597050a79..a221e3b01e4a6f3f1f6ef0af864f440c6b2f8a44 100644
--- a/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart
+++ b/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart
@@ -391,9 +391,7 @@ class Not extends Expression {
class FunctionExpression extends Expression implements DartSpecificNode {
final FunctionDefinition definition;
- FunctionExpression(this.definition) {
- assert(definition.element.type.returnType.treatAsDynamic);
- }
+ FunctionExpression(this.definition);
accept(ExpressionVisitor visitor) => visitor.visitFunctionExpression(this);
accept1(ExpressionVisitor1 visitor, arg) {
@@ -706,7 +704,7 @@ class FieldDefinition extends RootNode implements DartSpecificNode {
}
class FunctionDefinition extends RootNode {
- final FunctionElement element;
+ final ExecutableElement element;
final List<Variable> parameters;
Statement body;
final List<ConstDeclaration> localConstants;
@@ -873,6 +871,8 @@ class SetField extends Expression implements JsSpecificNode {
accept1(ExpressionVisitor1 visitor, arg) => visitor.visitSetField(this, arg);
}
+/// Read the value of a field, possibly provoking its initializer to evaluate,
+/// or tear off a static method.
class GetStatic extends Expression {
Element element;
SourceInformation sourceInformation;
@@ -883,7 +883,6 @@ class GetStatic extends Expression {
accept1(ExpressionVisitor1 visitor, arg) => visitor.visitGetStatic(this, arg);
}
-
class SetStatic extends Expression {
Element element;
Expression value;
« no previous file with comments | « pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart ('k') | tests/co19/co19-dart2js.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698