sdk/lib/utf/utf32.dart - Issue 11368138: Add some support for the code-point code-unit distinction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/utf/utf32.dart

Issue 11368138: Add some support for the code-point code-unit distinction. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Implemented feedback from patch set 3 Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/utf/utf32.dart

diff --git a/sdk/lib/utf/utf32.dart b/sdk/lib/utf/utf32.dart

index 9cbfd7aa982e14aabd5262ad3c3c6ac2257b1236..f79e45243342f2786da556eee9567dce8b6fe204 100644

--- a/sdk/lib/utf/utf32.dart

+++ b/sdk/lib/utf/utf32.dart

@@ -96,7 +96,7 @@ List<int> encodeUtf32(String str) =>

* UTF-32BE bytes with no BOM.

List<int> encodeUtf32be(String str, [bool writeBOM = false]) {

- List<int> utf32CodeUnits = stringToCodepoints(str);

+ List<int> utf32CodeUnits = str.charCodes();

List<int> encoding = new List<int>(4 * utf32CodeUnits.length +

(writeBOM ? 4 : 0));

int i = 0;

@@ -120,7 +120,7 @@ List<int> encodeUtf32be(String str, [bool writeBOM = false]) {