sdk/lib/_internal/compiler/implementation/string_validator.dart - Issue 11368138: Add some support for the code-point code-unit distinction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/string_validator.dart

Issue 11368138: Add some support for the code-point code-unit distinction. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Implemented feedback from patch set 3 Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« runtime/vm/unicode.h ('K') | « sdk/lib/_internal/compiler/implementation/source_map_builder.dart ('k') | sdk/lib/_internal/compiler/implementation/util/util.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/string_validator.dart

diff --git a/sdk/lib/_internal/compiler/implementation/string_validator.dart b/sdk/lib/_internal/compiler/implementation/string_validator.dart

index a5f15e218067e6b85a39ba45c28ced379726c840..81453082ec604553550970c5a31c191724e4468c 100644

--- a/sdk/lib/_internal/compiler/implementation/string_validator.dart

+++ b/sdk/lib/_internal/compiler/implementation/string_validator.dart

@@ -168,6 +168,8 @@ class StringValidator {

code = value;

}

+ // TODO(erikcorry): Use the string code point iterator when available.

+ if (code >= String.SMP_CODE_POINT_BASE) ++length;;

// This handles both unescaped characters and the value of unicode

// escapes.

if (!isUnicodeScalarValue(code)) {