sdk/lib/_internal/compiler/implementation/lib/core_patch.dart - Issue 11368138: Add some support for the code-point code-unit distinction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/core_patch.dart

Issue 11368138: Add some support for the code-point code-unit distinction. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Implemented feedback from patch set 3 Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« runtime/vm/unicode.h ('K') | « sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart ('k') | sdk/lib/_internal/compiler/implementation/lib/js_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/lib/core_patch.dart

diff --git a/sdk/lib/_internal/compiler/implementation/lib/core_patch.dart b/sdk/lib/_internal/compiler/implementation/lib/core_patch.dart

index 253c1fae32645dc68c44569a6efcd6bcd03c431a..7939b777c022979ecbc7f31b391971311b2f2cc3 100644

--- a/sdk/lib/_internal/compiler/implementation/lib/core_patch.dart

+++ b/sdk/lib/_internal/compiler/implementation/lib/core_patch.dart

@@ -168,13 +168,13 @@ patch class _ListImpl<E> {

patch class String {

- patch factory String.fromCharCodes(List<int> charCodes) {

- checkNull(charCodes);

- if (!isJsArray(charCodes)) {

- if (charCodes is !List) throw new ArgumentError(charCodes);

- charCodes = new List.from(charCodes);

+ patch factory String.fromCodeUnits(List<int> codeUnits) {

+ checkNull(codeUnits);

+ if (!isJsArray(codeUnits)) {

+ if (codeUnits is !List) throw new ArgumentError(codeUnits);

+ codeUnits = new List.from(codeUnits);

}

- return Primitives.stringFromCharCodes(charCodes);

+ return Primitives.stringFromCodeUnits(codeUnits);

}