runtime/vm/scopes.cc - Issue 11368138: Add some support for the code-point code-unit distinction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/scopes.cc

Issue 11368138: Add some support for the code-point code-unit distinction. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: New version integrates feedback, adds less to standard String class. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/scopes.cc

diff --git a/runtime/vm/scopes.cc b/runtime/vm/scopes.cc

index 588587c315e451fbea92713b50e5c6e69ed2ebfe..ee3f3b05caaf8db885c79f7e1e20f8d3876633e1 100644

--- a/runtime/vm/scopes.cc

+++ b/runtime/vm/scopes.cc

@@ -214,7 +214,7 @@ RawLocalVarDescriptors* LocalScope::GetVarDescriptors(const Function& func) {

// The parser creates internal variables that start with ":"

static bool IsInternalIdentifier(const String& str) {

ASSERT(str.Length() > 0);

- return str.CharAt(0) == ':';

+ return str.CodeUnitAt(0) == ':';

}

« runtime/vm/object.cc ('K') | « runtime/vm/scanner.cc ('k') | runtime/vm/symbols.cc » ('j') | runtime/vm/unicode.h » ('J')