sdk/lib/_internal/compiler/implementation/lib/js_helper.dart - Issue 11368138: Add some support for the code-point code-unit distinction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/js_helper.dart

Issue 11368138: Add some support for the code-point code-unit distinction. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Implemented feedback from patch set 2. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« runtime/vm/object.cc ('K') | « sdk/lib/_internal/compiler/implementation/lib/core_patch.dart ('k') | sdk/lib/_internal/compiler/implementation/lib/js_string.dart » ('j') | sdk/lib/core/string.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/lib/js_helper.dart

diff --git a/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart b/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart

index 392c140d87c54548c1d256b79a552bec816473f9..de4b27b3fab8939aca1531d972b9e2d8126f18dd 100644

--- a/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart

+++ b/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart

@@ -533,11 +533,12 @@ class Primitives {

static num dateNow() => JS('num', r'Date.now()');

- static String stringFromCharCodes(charCodes) {

- for (var i in charCodes) {

+ static String stringFromCodeUnits(codeUnits) {

+ for (var i in codeUnits) {

if (i is !int) throw new ArgumentError(i);

+ if (i > String.MAX_CODE_UNIT) throw new ArgumentError(i);

}

- return JS('String', r'String.fromCharCode.apply(#, #)', null, charCodes);

+ return JS('String', r'String.fromCharCode.apply(#, #)', null, codeUnits);

}

static String getTimeZoneName(receiver) {