runtime/vm/scanner.cc - Issue 11368138: Add some support for the code-point code-unit distinction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/scanner.cc

Issue 11368138: Add some support for the code-point code-unit distinction. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Implemented feedback from patch set 2. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/scanner.cc

diff --git a/runtime/vm/scanner.cc b/runtime/vm/scanner.cc

index 229dfdf36f0a9b06d37104a6ec56f31b1283bff0..5f3f1072b7f040815612af9aade015cf8d9a1193 100644

--- a/runtime/vm/scanner.cc

+++ b/runtime/vm/scanner.cc

@@ -498,7 +498,7 @@ void Scanner::ScanEscapedCodePoint(uint32_t* code_point) {

void Scanner::ScanLiteralStringChars(bool is_raw) {

- GrowableArray<uint32_t> string_chars(64);

+ GrowableArray<int32_t> string_chars(64);

ASSERT(IsScanningString());

// We are at the first character of a string literal piece. A string literal

« runtime/vm/object.cc ('K') | « runtime/vm/scanner.h ('k') | runtime/vm/symbols.cc » ('j') | sdk/lib/core/string.dart » ('J')