runtime/vm/dart_api_message.cc - Issue 11368138: Add some support for the code-point code-unit distinction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_message.cc

Issue 11368138: Add some support for the code-point code-unit distinction. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Implemented feedback from patch set 2. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart_api_message.cc

diff --git a/runtime/vm/dart_api_message.cc b/runtime/vm/dart_api_message.cc

index 6958098afc83ce69824e8c84de496b3a09ab158a..7141a82a3df18eafdd95a3ef56f6920c04b1dc34 100644

--- a/runtime/vm/dart_api_message.cc

+++ b/runtime/vm/dart_api_message.cc

@@ -767,7 +767,7 @@ bool ApiMessageWriter::WriteCObjectInlined(Dart_CObject* object,

}

Utf8::Type type;

- intptr_t len = Utf8::CodePointCount(utf8_str, utf8_len, &type);

+ intptr_t len = Utf8::CodeUnitCount(utf8_str, utf8_len, &type);

// Write out the serialization header value for this object.

WriteInlinedHeader(object);

« runtime/lib/string_patch.dart ('K') | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/object.h » ('j') | runtime/vm/object.h » ('J')