Make sure we build the tools used for testing minidumps on Android.

build/all_android.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This is all.gyp file for Android to prevent breakage in Android and other
 # platform; It will be churning a lot in the short term and eventually be merged
 # into all.gyp.
 
 {
   'variables': {
@@ skipping 47 matching lines @@
         # Required by ui_unittests.
         # TODO(wangxianzhu): It'd better let ui_unittests depend on it, but
         # this would cause circular gyp dependency which needs refactoring the
         # gyps to resolve.
         '../chrome/chrome_resources.gyp:packed_resources',
       ],
       'conditions': [
         ['linux_breakpad==1', {
           'dependencies': [
             '../breakpad/breakpad.gyp:breakpad_unittests',
+            'minidump_tools#host',
           ],
         }],
         ['"<(gtest_target_type)"=="shared_library"', {
           'dependencies': [
             # The first item is simply the template.  We add as a dep
             # to make sure it builds in ungenerated form.  TODO(jrg):
             # once stable, transition to a test-only (optional)
             # target.
             '../testing/android/native_test.gyp:native_test_apk',
             # Unit test bundles packaged as an apk.
             '../base/base.gyp:base_unittests_apk',
             '../cc/cc_tests.gyp:cc_unittests_apk',
             '../chrome/chrome.gyp:unit_tests_apk',
             '../content/content.gyp:content_unittests_apk',
             '../gpu/gpu.gyp:gpu_unittests_apk',
             '../ipc/ipc.gyp:ipc_tests_apk',
             '../media/media.gyp:media_unittests_apk',
             '../net/net.gyp:net_unittests_apk',
             '../sql/sql.gyp:sql_unittests_apk',
             '../sync/sync.gyp:sync_unit_tests_apk',
             '../ui/ui.gyp:ui_unittests_apk',
             '../android_webview/android_webview.gyp:android_webview_test_apk',
             '../chrome/chrome.gyp:chromium_testshell_test_apk',
             '../webkit/compositor_bindings/compositor_bindings_tests.gyp:webkit_compositor_bindings_unittests_apk'
           ],
         }],
       ],
     },
     {
+      'target_name': 'minidump_tools',

[Yaron, 2012/11/06 22:38:43]

Should the definition of this target be defined only for linux_breakpad=1?
Actually, this might be helpful.. it means that you can build the minidump_tools
target without linux_breakpad=1, right? Just want to make sure this doesn't
break the regular workflow which defaults to "All" and doesn't include this?

[Jay Civelli, 2012/11/06 22:54:47]

Yes, I think it might be helpful for the case you described.
I am not sure I am following you on how this could break the All workflow. These
were not built before for All, and still won't unless linux_breakpad is 1,
right?

+      'type': 'none',
+      'toolsets': [ 'host' ],
+      'dependencies': [
+        '../breakpad/breakpad.gyp:dump_syms',
+        '../breakpad/breakpad.gyp:symupload',
+        '../breakpad/breakpad.gyp:minidump_dump',
+        '../breakpad/breakpad.gyp:minidump_stackwalk'
+      ],
+    },
+    {
       # Experimental / in-progress targets that are expected to fail
       # but we still try to compile them on bots (turning the stage
       # orange, not red).
       'target_name': 'android_experimental',
       'type': 'none',
       'dependencies': [
       ],
     },
     {
       # In-progress targets that are expected to fail and are NOT run
       # on any bot.
       'target_name': 'android_in_progress',
       'type': 'none',
       'dependencies': [
         '../content/content.gyp:content_browsertests',
       ],
     },
   ],  # targets
 }