Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11368067: 'dep_os' paths override 'deps' paths. (Closed)

Created:
8 years, 1 month ago by Siva Chandra
Modified:
8 years, 1 month ago
Reviewers:
cmp, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel
Visibility:
Public.

Description

'dep_os' paths override 'deps' paths. BUG=157979 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166247

Patch Set 1 #

Patch Set 2 : Added a test #

Total comments: 3

Patch Set 3 : Fix a typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -2 lines) Patch
M gclient.py View 2 chunks +7 lines, -2 lines 0 comments Download
M tests/gclient_test.py View 1 2 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Siva Chandra
There are no tests yet. PTAL and tell me if I am thinking correct here. ...
8 years, 1 month ago (2012-11-03 00:43:52 UTC) #1
Siva Chandra
I have added a test in Patch Set 2.
8 years, 1 month ago (2012-11-05 19:42:16 UTC) #2
M-A Ruel
https://codereview.chromium.org/11368067/diff/3001/tests/gclient_test.py File tests/gclient_test.py (right): https://codereview.chromium.org/11368067/diff/3001/tests/gclient_test.py#newcode453 tests/gclient_test.py:453: options, _ = parser.parse_args(['--jobs', '1']) Why not use: '--deps', ...
8 years, 1 month ago (2012-11-05 19:48:05 UTC) #3
Siva Chandra
https://codereview.chromium.org/11368067/diff/3001/tests/gclient_test.py File tests/gclient_test.py (right): https://codereview.chromium.org/11368067/diff/3001/tests/gclient_test.py#newcode453 tests/gclient_test.py:453: options, _ = parser.parse_args(['--jobs', '1']) On 2012/11/05 19:48:05, Marc-Antoine ...
8 years, 1 month ago (2012-11-05 22:13:13 UTC) #4
M-A Ruel
lgtm https://codereview.chromium.org/11368067/diff/3001/tests/gclient_test.py File tests/gclient_test.py (right): https://codereview.chromium.org/11368067/diff/3001/tests/gclient_test.py#newcode453 tests/gclient_test.py:453: options, _ = parser.parse_args(['--jobs', '1']) On 2012/11/05 22:13:13, ...
8 years, 1 month ago (2012-11-06 15:13:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sivachandra@chromium.org/11368067/7001
8 years, 1 month ago (2012-11-06 19:38:46 UTC) #6
commit-bot: I haz the power
8 years, 1 month ago (2012-11-06 19:41:29 UTC) #7 
Change committed as 166247

Powered by Google App Engine
This is Rietveld 408576698