Handle FFmpeg initialization in a lazy instance.

Handle FFmpeg initialization in a lazy instance.

Sadly function level static initialization is not thread safe on
MSVC (though it is on clang/gcc), so we need to switch back to
using a lazy instance to manage ffmpeg initialization :(

See "magic statics":
http://msdn.microsoft.com/en-us/library/vstudio/hh567368.aspx

BUG=159139
TEST=tests pass.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165835

[DaleCurtis, 2012-11-02 23:34:05]

scherkus: please review.
jyasskin: FYI, thanks for the help!

[scherkus (not reviewing), 2012-11-02 23:39:28]

The More You Know(tm)

lgtm

https://codereview.chromium.org/11368064/diff/1/media/filters/ffmpeg_glue.cc
File media/filters/ffmpeg_glue.cc (right):

https://codereview.chromium.org/11368064/diff/1/media/filters/ffmpeg_glue.cc#...
media/filters/ffmpeg_glue.cc:110: ~FFmpegInitializer() {
I wonder if this ever gets called :)

[DaleCurtis, 2012-11-02 23:45:55]

https://codereview.chromium.org/11368064/diff/1/media/filters/ffmpeg_glue.cc
File media/filters/ffmpeg_glue.cc (right):

https://codereview.chromium.org/11368064/diff/1/media/filters/ffmpeg_glue.cc#...
media/filters/ffmpeg_glue.cc:110: ~FFmpegInitializer() {
On 2012/11/02 23:39:28, scherkus wrote:
> I wonder if this ever gets called :)

Yes, unless you declare it as:

static base::LazyInstance<DeleteLogger>::Leaky li = ...

Which I think we should do since we don't actually need to remove the lock
manager and sail mentioned AtExit stuff slows down mac shutdown.  WDYT?

[scherkus (not reviewing), 2012-11-02 23:48:05]

https://codereview.chromium.org/11368064/diff/1/media/filters/ffmpeg_glue.cc
File media/filters/ffmpeg_glue.cc (right):

https://codereview.chromium.org/11368064/diff/1/media/filters/ffmpeg_glue.cc#...
media/filters/ffmpeg_glue.cc:110: ~FFmpegInitializer() {
On 2012/11/02 23:45:55, DaleCurtis wrote:
> On 2012/11/02 23:39:28, scherkus wrote:
> > I wonder if this ever gets called :)
> 
> Yes, unless you declare it as:
> 
> static base::LazyInstance<DeleteLogger>::Leaky li = ...
> 
> Which I think we should do since we don't actually need to remove the lock
> manager and sail mentioned AtExit stuff slows down mac shutdown.  WDYT?

I'm ok w/ a leaky FFmpeg initializer. This is essentially called when loading
the library into address space and it's not like we need to cleanly unload the
library at certain points in time.

[DaleCurtis, 2012-11-02 23:49:39]

https://codereview.chromium.org/11368064/diff/1/media/filters/ffmpeg_glue.cc
File media/filters/ffmpeg_glue.cc (right):

https://codereview.chromium.org/11368064/diff/1/media/filters/ffmpeg_glue.cc#...
media/filters/ffmpeg_glue.cc:110: ~FFmpegInitializer() {
On 2012/11/02 23:48:05, scherkus wrote:
> On 2012/11/02 23:45:55, DaleCurtis wrote:
> > On 2012/11/02 23:39:28, scherkus wrote:
> > > I wonder if this ever gets called :)
> > 
> > Yes, unless you declare it as:
> > 
> > static base::LazyInstance<DeleteLogger>::Leaky li = ...
> > 
> > Which I think we should do since we don't actually need to remove the lock
> > manager and sail mentioned AtExit stuff slows down mac shutdown.  WDYT?
> 
> I'm ok w/ a leaky FFmpeg initializer. This is essentially called when loading
> the library into address space and it's not like we need to cleanly unload the
> library at certain points in time.

Done.

[commit-bot: I haz the power, 2012-11-02 23:49:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/11368064/5001

[commit-bot: I haz the power, 2012-11-03 02:42:52]

Change committed as 165835