Chromium Code Reviews
Help | Chromium Project | Sign in
(142)

Issue 11368061: Insert empty line at to fix patch. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 8 months ago by noelallen1
Modified:
2 years, 8 months ago
Reviewers:
bradnelson
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Insert empty line at to fix patch. gyptest-link-pdb.py was checked in without a blank line. This appears to cause a patch issue with the try bots. This CL is only a whitespace change to attempt to fix that problem. SEE: patching file test/win/gyptest-link-pdb.py Hunk #1 FAILED at 26. 1 out of 1 hunk FAILED -- saving rejects to file test/win/gyptest-link-pdb.py.rej =================================================================== --- test/win/gyptest-link-pdb.py (revision 1530) +++ test/win/gyptest-link-pdb.py (working copy) @@ -26,7 +26,9 @@ # Verify the specified PDB is created when ProgramDatabaseFile # is provided. - if not FindFile('name_set.pdb'): + if not FindFile('name_outdir.pdb'): test.fail_test() - else: - test.pass_test() \ No newline at end of file + if not FindFile('name_proddir.pdb'): + test.fail_test() + + test.pass_test() Index: test/win/linker-flags/program-database.gyp TBR=bradnelson@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1531

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/win/gyptest-link-pdb.py View 1 chunk +1 line, -1 line 0 comments Download
Commit: CQ not working?

Messages

Total messages: 1 (0 generated)
noelallen1
2 years, 8 months ago (2012-11-02 23:04:51 UTC) #1

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1f9106d