src/assembler_ia32.h - Issue 1136793002: Handle ARM "ret void" and function alignment with proper padding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/assembler_ia32.h

Issue 1136793002: Handle ARM "ret void" and function alignment with proper padding. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: note moved to cpp Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/assembler_ia32.h

diff --git a/src/assembler_ia32.h b/src/assembler_ia32.h

index 4cb6ee78239ac82899dd9163659602b2354d573b..f5675167be4d29da48580f1dbb4450aeb35b139b 100644

--- a/src/assembler_ia32.h

+++ b/src/assembler_ia32.h

@@ -352,6 +352,8 @@ public:

SizeT getBundleAlignLog2Bytes() const override { return 5; }

+ const char *getNonExecPadDirective() const override { return ".p2align"; }

llvm::ArrayRef<uint8_t> getNonExecBundlePadding() const override {

static const uint8_t Padding[] = {0xF4};

return llvm::ArrayRef<uint8_t>(Padding, 1);

« no previous file with comments | « src/assembler_arm32.h ('k') | tests_lit/llvm2ice_tests/function_aligned.ll » ('j') | no next file with comments »