src/IceCfg.cpp - Issue 1136793002: Handle ARM "ret void" and function alignment with proper padding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceCfg.cpp

Issue 1136793002: Handle ARM "ret void" and function alignment with proper padding. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: note moved to cpp Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceCfg.cpp

diff --git a/src/IceCfg.cpp b/src/IceCfg.cpp

index e0f48ab00d0e7e1c8fbbc91a517f071a4db71078..5b5c32b834adcd202452af1dc82162ef2294813a 100644

--- a/src/IceCfg.cpp

+++ b/src/IceCfg.cpp

@@ -464,9 +464,10 @@ void Cfg::emitTextHeader(const IceString &MangledName, GlobalContext *Ctx,

Str << "\t.section\t.text." << MangledName << ",\"ax\",@progbits\n";

if (!Asm->getInternal() || Ctx->getFlags().getDisableInternal()) {

Str << "\t.globl\t" << MangledName << "\n";

- Str << "\t.type\t" << MangledName << ",@function\n";

+ Str << "\t.type\t" << MangledName << ",%function\n";

}

- Str << "\t.p2align " << Asm->getBundleAlignLog2Bytes() << ",0x";

+ Str << "\t" << Asm->getNonExecPadDirective() << " "

+ << Asm->getBundleAlignLog2Bytes() << ",0x";

for (uint8_t I : Asm->getNonExecBundlePadding())

Str.write_hex(I);

Str << "\n";

« no previous file with comments | « pydir/run-pnacl-sz.py ('k') | src/IceClFlags.h » ('j') | no next file with comments »